Add TE import guard in qwen2vl vision module#14091
Merged
chtruong814 merged 2 commits intomainfrom Jul 1, 2025
Merged
Conversation
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
94bd14e to
b122b44
Compare
Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com>
thomasdhc
approved these changes
Jul 1, 2025
Collaborator
Author
|
This is just adding an import guard. Will go ahead and fast merge this. |
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Jul 23, 2025
* Add TE import guard in qwen2vl vision module Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Apply isort and black reformatting Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com> --------- Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com> Co-authored-by: chtruong814 <chtruong814@users.noreply.github.com> Signed-off-by: Amir Hussein <amhussein@nvidia.com>
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Aug 5, 2025
* Add TE import guard in qwen2vl vision module Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Apply isort and black reformatting Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com> --------- Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com> Co-authored-by: chtruong814 <chtruong814@users.noreply.github.com> Signed-off-by: Amir Hussein <amhussein@nvidia.com>
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Aug 5, 2025
* Add TE import guard in qwen2vl vision module Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Apply isort and black reformatting Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com> --------- Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com> Co-authored-by: chtruong814 <chtruong814@users.noreply.github.com> Signed-off-by: Amir Hussein <amhussein@nvidia.com>
nasretdinovr
pushed a commit
to nasretdinovr/NeMo
that referenced
this pull request
Aug 8, 2025
* Add TE import guard in qwen2vl vision module Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Apply isort and black reformatting Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com> --------- Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com> Co-authored-by: chtruong814 <chtruong814@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add TE import guard in qwen2vl vision module
Otherwise, this requires TE to be installed in a nemo-run environment to launch jobs.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information