Skip to content

Cherry pick Fix broken link in Reasoning-SFT.ipynb (14716) into r2.5.0#14717

Merged
chtruong814 merged 1 commit intor2.5.0from
cherry-pick-14716-r2.5.0
Sep 11, 2025
Merged

Cherry pick Fix broken link in Reasoning-SFT.ipynb (14716) into r2.5.0#14717
chtruong814 merged 1 commit intor2.5.0from
cherry-pick-14716-r2.5.0

Conversation

@chtruong814
Copy link
Collaborator

beep boop [🤖]: Hi @cuichenx 👋,

we've cherry picked #14716 into  for you! 🚀

Please review and approve this cherry pick by your convenience!

Signed-off-by: Chen Cui <chcui@nvidia.com>
@github-actions
Copy link
Contributor

[🤖]: Hi @chtruong814 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

@github-actions github-actions bot removed the Run CICD label Sep 10, 2025
@chtruong814 chtruong814 merged commit 0c4c2d1 into r2.5.0 Sep 11, 2025
73 of 80 checks passed
@chtruong814 chtruong814 deleted the cherry-pick-14716-r2.5.0 branch September 11, 2025 00:00
erastorgueva-nv pushed a commit that referenced this pull request Sep 15, 2025
Signed-off-by: Chen Cui <chcui@nvidia.com>
Co-authored-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>
chtruong814 added a commit that referenced this pull request Sep 16, 2025
…ite (#14715)

* comment out x = x.float()

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

* Update Reasoning-SFT.ipynb (#14716) (#14717)

Signed-off-by: Chen Cui <chcui@nvidia.com>
Co-authored-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

* cast SE weights and activations to fp32

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

---------

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Co-authored-by: Charlie Truong <chtruong@nvidia.com>
Co-authored-by: Chen Cui <chcui@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants