Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions scripts/performance/argument_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -422,5 +422,12 @@ def list_of_strings(arg):
required=False,
default=False,
)
parser.add_argument(
"--detach",
help="Detach from experiment. Default is True. Unset to keep the process running.",
type=bool_arg,
required=False,
default=True,
)

return parser
2 changes: 1 addition & 1 deletion scripts/performance/diffusion/pretrain_flux_12b.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,6 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()
2 changes: 1 addition & 1 deletion scripts/performance/llm/finetune_deepseek_v3.py
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,6 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()
2 changes: 1 addition & 1 deletion scripts/performance/llm/finetune_llama31_405b.py
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,6 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()
2 changes: 1 addition & 1 deletion scripts/performance/llm/finetune_llama3_70b.py
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,6 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()
2 changes: 1 addition & 1 deletion scripts/performance/llm/finetune_llama3_8b.py
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,6 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()
2 changes: 1 addition & 1 deletion scripts/performance/llm/finetune_llama4_e128.py
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,6 @@ def override_recipe_configs(
plugins=plugins,
)
if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()
2 changes: 1 addition & 1 deletion scripts/performance/llm/mlperf_lora_llama2_70b.py
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,6 @@ def mlperf_lora_llama2_70b_recipe(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()
2 changes: 1 addition & 1 deletion scripts/performance/llm/pretrain_automodel_llama3_8b.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,6 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()
2 changes: 1 addition & 1 deletion scripts/performance/llm/pretrain_deepseek_v3.py
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()

Expand Down
2 changes: 1 addition & 1 deletion scripts/performance/llm/pretrain_gpt3_175b.py
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()

Expand Down
4 changes: 2 additions & 2 deletions scripts/performance/llm/pretrain_llama31_405b.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ def override_recipe_configs(
recipe.trainer.callbacks[comm_overlap_callback_idx].tp_comm_overlap_cfg = tp_comm_overlap_cfg

if use_mcore_fsdp and gpu_type == 'gb200':
recipe.trainer.strategy.num_distributed_optimizer_instances = (num_nodes * 4) / 64
recipe.trainer.strategy.num_distributed_optimizer_instances = (num_nodes * 4) // 64

return recipe

Expand Down Expand Up @@ -223,7 +223,7 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()

Expand Down
2 changes: 1 addition & 1 deletion scripts/performance/llm/pretrain_llama3_70b.py
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()

Expand Down
2 changes: 1 addition & 1 deletion scripts/performance/llm/pretrain_llama3_8b.py
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()

Expand Down
2 changes: 1 addition & 1 deletion scripts/performance/llm/pretrain_llama4_e128.py
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()

Expand Down
2 changes: 1 addition & 1 deletion scripts/performance/llm/pretrain_llama4_e16.py
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()

Expand Down
2 changes: 1 addition & 1 deletion scripts/performance/llm/pretrain_mixtral_8x22b.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,6 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()
2 changes: 1 addition & 1 deletion scripts/performance/llm/pretrain_mixtral_8x7b.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,6 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()
2 changes: 1 addition & 1 deletion scripts/performance/llm/pretrain_nemotron3_22b.py
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,6 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()
2 changes: 1 addition & 1 deletion scripts/performance/llm/pretrain_nemotron3_8b.py
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,6 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()
2 changes: 1 addition & 1 deletion scripts/performance/llm/pretrain_nemotron4_15b.py
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,6 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()
2 changes: 1 addition & 1 deletion scripts/performance/llm/pretrain_nemotron4_340b.py
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,6 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()
2 changes: 1 addition & 1 deletion scripts/performance/llm/pretrain_nemotronh_47b.py
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()

Expand Down
2 changes: 1 addition & 1 deletion scripts/performance/llm/pretrain_nemotronh_56b.py
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()

Expand Down
2 changes: 1 addition & 1 deletion scripts/performance/llm/pretrain_nemotronh_8b.py
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()

Expand Down
2 changes: 1 addition & 1 deletion scripts/performance/llm/pretrain_qwen3_235b_a22b.py
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()

Expand Down
2 changes: 1 addition & 1 deletion scripts/performance/llm/pretrain_qwen3_30b_a3b.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()

Expand Down
2 changes: 1 addition & 1 deletion scripts/performance/vlm/finetune_neva_8b.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,6 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()
2 changes: 1 addition & 1 deletion scripts/performance/vlm/finetune_qwen25vl_32b.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,6 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()
2 changes: 1 addition & 1 deletion scripts/performance/vlm/finetune_qwen25vl_7b.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,6 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()
2 changes: 1 addition & 1 deletion scripts/performance/vlm/pretrain_vlm_llama4_e128.py
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,6 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()
2 changes: 1 addition & 1 deletion scripts/performance/vlm/pretrain_vlm_llama4_e16.py
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,6 @@ def override_recipe_configs(
)

if not args.dryrun:
exp.run(sequential=True, detach=True)
exp.run(sequential=True, detach=args.detach)
else:
exp.dryrun()
Loading