Add import guards for mcore lightning module#14970
Merged
chtruong814 merged 4 commits intomainfrom Oct 24, 2025
Merged
Conversation
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
nithinraok
previously approved these changes
Oct 23, 2025
Member
nithinraok
left a comment
nithinraok
left a comment
There was a problem hiding this comment.
Quick fix LGTM, however these need to be updated accordingly. There is no need to import Megatron core related packages while using OneLogger
nithinraok
reviewed
Oct 23, 2025
Member
nithinraok
left a comment
nithinraok
left a comment
There was a problem hiding this comment.
Should we add a pip install .['asr'] and also check for successful import after the install?
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
chtruong814
requested review from
ko3n1g,
pablo-garay and
thomasdhc
as code owners
Contributor
|
[🤖]: Hi @chtruong814 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
pablo-garay
approved these changes
Oct 24, 2025
chtruong814
added a commit
that referenced
this pull request
Oct 24, 2025
* Add import guards for mcore lightning module Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Apply isort and black reformatting Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com> * Add import guard for Apex Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Add asr install checker Signed-off-by: Charlie Truong <chtruong@nvidia.com> --------- Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com> Co-authored-by: chtruong814 <chtruong814@users.noreply.github.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
chtruong814
added
r2.5.0
chtruong814
added a commit
that referenced
this pull request
Oct 24, 2025
* Add import guards for mcore lightning module Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Apply isort and black reformatting Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com> * Add import guard for Apex Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Add asr install checker Signed-off-by: Charlie Truong <chtruong@nvidia.com> --------- Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com> Co-authored-by: chtruong814 <chtruong814@users.noreply.github.com> Signed-off-by: Charlie Truong <chtruong@nvidia.com>
8 tasks
chtruong814
added a commit
that referenced
this pull request
Oct 27, 2025
…5.0` (#14982) * Add import guards for mcore lightning module (#14970) * Add import guards for mcore lightning module Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Apply isort and black reformatting Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com> * Add import guard for Apex Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Add asr install checker Signed-off-by: Charlie Truong <chtruong@nvidia.com> --------- Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com> Co-authored-by: chtruong814 <chtruong814@users.noreply.github.com> Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Apply isort and black reformatting Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com> --------- Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com> Co-authored-by: chtruong814 <chtruong814@users.noreply.github.com>
chtruong814
added a commit
that referenced
this pull request
Nov 4, 2025
* Add import guards for mcore lightning module * Apply isort and black reformatting * Add import guard for Apex * Add asr install checker --------- Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com> Co-authored-by: chtruong814 <chtruong814@users.noreply.github.com>
quapham
pushed a commit
to quapham/NeMo
that referenced
this pull request
Dec 16, 2025
* Add import guards for mcore lightning module Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Apply isort and black reformatting Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com> * Add import guard for Apex Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Add asr install checker Signed-off-by: Charlie Truong <chtruong@nvidia.com> --------- Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com> Co-authored-by: chtruong814 <chtruong814@users.noreply.github.com> Signed-off-by: quanpham <youngkwan199@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add import guards for mcore lightning module
After adding one logger across the repo, it's importing the lightning module in ASR. However, this also assumes that MCore is installed. ASR does not need MCore, so we import guard MCore in the lightning module for now.
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information