Skip to content

Update deprecated env var#14975

Merged
maanug-nv merged 4 commits intomainfrom
maanug/perf-hf-env-var
Oct 31, 2025
Merged

Update deprecated env var#14975
maanug-nv merged 4 commits intomainfrom
maanug/perf-hf-env-var

Conversation

@maanug-nv
Copy link
Collaborator

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Maanu Grover <maanug@nvidia.com>
@maanug-nv maanug-nv requested a review from malay-nagda October 23, 2025 20:10
@maanug-nv maanug-nv enabled auto-merge (squash) October 23, 2025 20:10
@coderabbitai
Copy link

coderabbitai bot commented Oct 23, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch maanug/perf-hf-env-var

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

[🤖]: Hi @maanug-nv 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

@github-actions github-actions bot removed the NLP label Oct 28, 2025
@maanug-nv maanug-nv added bug Something isn't working Run CICD support labels Oct 31, 2025
@github-actions github-actions bot removed the Run CICD label Oct 31, 2025
@github-actions
Copy link
Contributor

[🤖]: Hi @maanug-nv 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

@github-actions
Copy link
Contributor

[🤖]: Hi @maanug-nv 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

@github-actions github-actions bot removed the Run CICD label Oct 31, 2025
@maanug-nv maanug-nv merged commit b515e73 into main Oct 31, 2025
57 checks passed
@maanug-nv maanug-nv deleted the maanug/perf-hf-env-var branch October 31, 2025 20:32
quapham pushed a commit to quapham/NeMo that referenced this pull request Dec 16, 2025
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: quanpham <youngkwan199@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants