Skip to content

check asr models#14989

Merged
nithinraok merged 4 commits intomainfrom
pytorch_weights_only_asr_models
Oct 29, 2025
Merged

check asr models#14989
nithinraok merged 4 commits intomainfrom
pytorch_weights_only_asr_models

Conversation

@nithinraok
Copy link
Member

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Fixes pytorch security bug during pickle deserialization when weights_only=False

Collection: ASR

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
@github-actions github-actions bot added the core Changes to NeMo Core label Oct 27, 2025
nithinraok and others added 2 commits October 27, 2025 17:00
Signed-off-by: nithinraok <nithinraok@users.noreply.github.com>
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
@github-actions
Copy link
Contributor

[🤖]: Hi @nithinraok 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

@nithinraok nithinraok enabled auto-merge (squash) October 29, 2025 14:01
@nithinraok nithinraok requested a review from ericharper October 29, 2025 14:37
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nithinraok nithinraok merged commit 59854cb into main Oct 29, 2025
269 of 275 checks passed
@nithinraok nithinraok deleted the pytorch_weights_only_asr_models branch October 29, 2025 16:45
@chtruong814 chtruong814 added the r2.6.0 Cherry-pick label for the r2.6.0 release branch label Oct 29, 2025
chtruong814 added a commit that referenced this pull request Oct 29, 2025
* check asr models

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>

* Apply isort and black reformatting

Signed-off-by: nithinraok <nithinraok@users.noreply.github.com>

* update return

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>

---------

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: nithinraok <nithinraok@users.noreply.github.com>
Co-authored-by: nithinraok <nithinraok@users.noreply.github.com>
Co-authored-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
@chtruong814 chtruong814 added r2.5.0 Cherry-pick label for the 2.5.0 release and removed r2.6.0 Cherry-pick label for the r2.6.0 release branch labels Nov 1, 2025
chtruong814 added a commit that referenced this pull request Nov 1, 2025
* check asr models

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>

* Apply isort and black reformatting

Signed-off-by: nithinraok <nithinraok@users.noreply.github.com>

* update return

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>

---------

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: nithinraok <nithinraok@users.noreply.github.com>
Co-authored-by: nithinraok <nithinraok@users.noreply.github.com>
Co-authored-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
chtruong814 added a commit that referenced this pull request Nov 1, 2025
* check asr models



* Apply isort and black reformatting



* update return



---------

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: nithinraok <nithinraok@users.noreply.github.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com>
Co-authored-by: nithinraok <nithinraok@users.noreply.github.com>
chtruong814 added a commit that referenced this pull request Nov 4, 2025
* check asr models (#14989)

* check asr models

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>

* Apply isort and black reformatting

Signed-off-by: nithinraok <nithinraok@users.noreply.github.com>

* update return

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>

---------

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: nithinraok <nithinraok@users.noreply.github.com>
Co-authored-by: nithinraok <nithinraok@users.noreply.github.com>
Co-authored-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>

* Pass timeout when running speech functional tests (#15012)

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

* Add timeout to speech test

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

* Use cpu runner for asr cpu unit tests

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

---------

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: nithinraok <nithinraok@users.noreply.github.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com>
Co-authored-by: nithinraok <nithinraok@users.noreply.github.com>
quapham pushed a commit to quapham/NeMo that referenced this pull request Dec 16, 2025
* check asr models

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>

* Apply isort and black reformatting

Signed-off-by: nithinraok <nithinraok@users.noreply.github.com>

* update return

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>

---------

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: nithinraok <nithinraok@users.noreply.github.com>
Co-authored-by: nithinraok <nithinraok@users.noreply.github.com>
Co-authored-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: quanpham <youngkwan199@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Changes to NeMo Core r2.5.0 Cherry-pick label for the 2.5.0 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants