Skip to content

Final pre-release updates#11

Merged
shashank3959 merged 2 commits intomainfrom
feat/release-prep
Oct 28, 2025
Merged

Final pre-release updates#11
shashank3959 merged 2 commits intomainfrom
feat/release-prep

Conversation

@chrisalexiuk-nvidia
Copy link
Copy Markdown
Contributor

@chrisalexiuk-nvidia chrisalexiuk-nvidia commented Oct 28, 2025

Add use-case examples and update the README

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>
Copy link
Copy Markdown
Contributor

@shashank3959 shashank3959 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the link and remove coming soon

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>
@shashank3959 shashank3959 merged commit f8780ec into main Oct 28, 2025
1 check passed
marcromeyn added a commit that referenced this pull request Dec 15, 2025
* Fix broken links to usage-recipes (#9)

Also updates a typo - usage cookbooks are now available, and examples are coming soon.

Signed-off-by: Shashank Verma <shashank3959@gmail.com>

* Final Pre-release commit (#10)

* Examples Directory

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Examples Directory

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* add Nemotron_Parse_V1_1.ipynb &  Nemotron_Nano2_VL.ipynb to usage-cookbook

* update Nemotron-Parse endpoint URL

* docs: add Nemotron Ideas Portal feature voting section to README

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

---------

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>
Co-authored-by: Chia-Chih Chen <chiachihc@nvidia.com>

* Final pre-release updates (#11)

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

---------

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Bug/rename notebook (#12)

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

---------

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Nemotron Parse v1.1 and Nemotron Nano 2 VL notebook README.md (#13)

Signed-off-by: Chia-Chih Chen <chiachihc@nvidia.com>

* Add Data Science ML Agent Use Case Example (#14)

* Add Data Science ML Agent example

Signed-off-by: Allison Ding <allison.j.ding@gmail.com>

* Add data folder with .gitkeep

Signed-off-by: Allison Ding <allison.j.ding@gmail.com>

* update the README.md in use-case-examples

Signed-off-by: Allison Ding <allison.j.ding@gmail.com>

* update the README in ds ml agent

Signed-off-by: Allison Ding <allison.j.ding@gmail.com>

---------

Signed-off-by: Allison Ding <allison.j.ding@gmail.com>

* Adding structure

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Adding data_prep

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Adding data-prep for nano-3

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Adding nemotron.kit

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Allowing defaults

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Integrate run

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Fixing data prep

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Improving wandb artifact integration

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Various improvements

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes (#7)

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* End of day commit

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

---------

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Remove tui for now (#8)

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Removing tui properly (#9)

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Move data-prep configs (#10)

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Adding structure (#11)

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes for pre-training (#12)

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Fix linting

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Disable CI for now

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

---------

Signed-off-by: Shashank Verma <shashank3959@gmail.com>
Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>
Signed-off-by: Chia-Chih Chen <chiachihc@nvidia.com>
Signed-off-by: Allison Ding <allison.j.ding@gmail.com>
Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>
Co-authored-by: Shashank Verma <shashank3959@gmail.com>
Co-authored-by: Chris Alexiuk <161380339+chrisalexiuk-nvidia@users.noreply.github.com>
Co-authored-by: Chia-Chih Chen <chiachihc@nvidia.com>
Co-authored-by: Allison Ding <141533440+AllisonDing@users.noreply.github.com>
marcromeyn added a commit that referenced this pull request Dec 16, 2025
* Fix broken links to usage-recipes (#9)

Also updates a typo - usage cookbooks are now available, and examples are coming soon.

Signed-off-by: Shashank Verma <shashank3959@gmail.com>

* Final Pre-release commit (#10)

* Examples Directory

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Examples Directory

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* add Nemotron_Parse_V1_1.ipynb &  Nemotron_Nano2_VL.ipynb to usage-cookbook

* update Nemotron-Parse endpoint URL

* docs: add Nemotron Ideas Portal feature voting section to README

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

---------

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>
Co-authored-by: Chia-Chih Chen <chiachihc@nvidia.com>

* Final pre-release updates (#11)

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

---------

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Bug/rename notebook (#12)

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

---------

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Nemotron Parse v1.1 and Nemotron Nano 2 VL notebook README.md (#13)

Signed-off-by: Chia-Chih Chen <chiachihc@nvidia.com>

* Add Data Science ML Agent Use Case Example (#14)

* Add Data Science ML Agent example

Signed-off-by: Allison Ding <allison.j.ding@gmail.com>

* Add data folder with .gitkeep

Signed-off-by: Allison Ding <allison.j.ding@gmail.com>

* update the README.md in use-case-examples

Signed-off-by: Allison Ding <allison.j.ding@gmail.com>

* update the README in ds ml agent

Signed-off-by: Allison Ding <allison.j.ding@gmail.com>

---------

Signed-off-by: Allison Ding <allison.j.ding@gmail.com>

* Adding structure

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Adding data_prep

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Adding data-prep for nano-3

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Adding nemotron.kit

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Allowing defaults

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Integrate run

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Fixing data prep

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Improving wandb artifact integration

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Various improvements

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes (#7)

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* End of day commit

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

---------

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Remove tui for now (#8)

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Removing tui properly (#9)

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Move data-prep configs (#10)

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Adding structure (#11)

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes for pre-training (#12)

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Fix linting

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Disable CI for now

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

---------

Signed-off-by: Shashank Verma <shashank3959@gmail.com>
Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>
Signed-off-by: Chia-Chih Chen <chiachihc@nvidia.com>
Signed-off-by: Allison Ding <allison.j.ding@gmail.com>
Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>
Co-authored-by: Shashank Verma <shashank3959@gmail.com>
Co-authored-by: Chris Alexiuk <161380339+chrisalexiuk-nvidia@users.noreply.github.com>
Co-authored-by: Chia-Chih Chen <chiachihc@nvidia.com>
Co-authored-by: Allison Ding <141533440+AllisonDing@users.noreply.github.com>
marcromeyn added a commit that referenced this pull request Dec 18, 2025
* Fix broken links to usage-recipes (#9)

Also updates a typo - usage cookbooks are now available, and examples are coming soon.

Signed-off-by: Shashank Verma <shashank3959@gmail.com>

* Final Pre-release commit (#10)

* Examples Directory

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Examples Directory

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* add Nemotron_Parse_V1_1.ipynb &  Nemotron_Nano2_VL.ipynb to usage-cookbook

* update Nemotron-Parse endpoint URL

* docs: add Nemotron Ideas Portal feature voting section to README

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

---------

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>
Co-authored-by: Chia-Chih Chen <chiachihc@nvidia.com>

* Final pre-release updates (#11)

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

---------

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Bug/rename notebook (#12)

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

---------

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Nemotron Parse v1.1 and Nemotron Nano 2 VL notebook README.md (#13)

Signed-off-by: Chia-Chih Chen <chiachihc@nvidia.com>

* Add Data Science ML Agent Use Case Example (#14)

* Add Data Science ML Agent example

Signed-off-by: Allison Ding <allison.j.ding@gmail.com>

* Add data folder with .gitkeep

Signed-off-by: Allison Ding <allison.j.ding@gmail.com>

* update the README.md in use-case-examples

Signed-off-by: Allison Ding <allison.j.ding@gmail.com>

* update the README in ds ml agent

Signed-off-by: Allison Ding <allison.j.ding@gmail.com>

---------

Signed-off-by: Allison Ding <allison.j.ding@gmail.com>

* Adding structure

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Adding data_prep

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Adding data-prep for nano-3

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Adding nemotron.kit

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Allowing defaults

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Integrate run

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Fixing data prep

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Improving wandb artifact integration

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Various improvements

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes (#7)

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* End of day commit

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

---------

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Remove tui for now (#8)

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Removing tui properly (#9)

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Move data-prep configs (#10)

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Adding structure (#11)

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes for pre-training (#12)

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Fix linting

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Disable CI for now

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

---------

Signed-off-by: Shashank Verma <shashank3959@gmail.com>
Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>
Signed-off-by: Chia-Chih Chen <chiachihc@nvidia.com>
Signed-off-by: Allison Ding <allison.j.ding@gmail.com>
Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>
Co-authored-by: Shashank Verma <shashank3959@gmail.com>
Co-authored-by: Chris Alexiuk <161380339+chrisalexiuk-nvidia@users.noreply.github.com>
Co-authored-by: Chia-Chih Chen <chiachihc@nvidia.com>
Co-authored-by: Allison Ding <141533440+AllisonDing@users.noreply.github.com>
marcromeyn added a commit that referenced this pull request Mar 10, 2026
* Fix broken links to usage-recipes (#9)

Also updates a typo - usage cookbooks are now available, and examples are coming soon.

Signed-off-by: Shashank Verma <shashank3959@gmail.com>

* Final Pre-release commit (#10)

* Examples Directory

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Examples Directory

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* add Nemotron_Parse_V1_1.ipynb &  Nemotron_Nano2_VL.ipynb to usage-cookbook

* update Nemotron-Parse endpoint URL

* docs: add Nemotron Ideas Portal feature voting section to README

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

---------

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>
Co-authored-by: Chia-Chih Chen <chiachihc@nvidia.com>

* Final pre-release updates (#11)

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

---------

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Bug/rename notebook (#12)

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Final pre-release updates

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

---------

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>

* Nemotron Parse v1.1 and Nemotron Nano 2 VL notebook README.md (#13)

Signed-off-by: Chia-Chih Chen <chiachihc@nvidia.com>

* Add Data Science ML Agent Use Case Example (#14)

* Add Data Science ML Agent example

Signed-off-by: Allison Ding <allison.j.ding@gmail.com>

* Add data folder with .gitkeep

Signed-off-by: Allison Ding <allison.j.ding@gmail.com>

* update the README.md in use-case-examples

Signed-off-by: Allison Ding <allison.j.ding@gmail.com>

* update the README in ds ml agent

Signed-off-by: Allison Ding <allison.j.ding@gmail.com>

---------

Signed-off-by: Allison Ding <allison.j.ding@gmail.com>

* Adding structure

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Adding data_prep

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Adding data-prep for nano-3

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Adding nemotron.kit

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Allowing defaults

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Integrate run

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Fixing data prep

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Improving wandb artifact integration

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Various improvements

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes (#7)

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* End of day commit

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

---------

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Remove tui for now (#8)

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Removing tui properly (#9)

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Move data-prep configs (#10)

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Adding structure (#11)

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Some fixes for pre-training (#12)

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Fix linting

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

* Disable CI for now

Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>

---------

Signed-off-by: Shashank Verma <shashank3959@gmail.com>
Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>
Signed-off-by: Chia-Chih Chen <chiachihc@nvidia.com>
Signed-off-by: Allison Ding <allison.j.ding@gmail.com>
Signed-off-by: Marc Romeyn <marcromeyn@gmail.com>
Co-authored-by: Shashank Verma <shashank3959@gmail.com>
Co-authored-by: Chris Alexiuk <161380339+chrisalexiuk-nvidia@users.noreply.github.com>
Co-authored-by: Chia-Chih Chen <chiachihc@nvidia.com>
Co-authored-by: Allison Ding <141533440+AllisonDing@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants