Fix missing include of <cuda/std/utility>#1078
Merged
cliffburdick merged 1 commit intoNVIDIA:mainfrom Oct 27, 2025
Merged
Conversation
We are using `cuda::std::as_const`. However, we relied on a transitive include from `<cuda/std/tuple>` that will be remove in a future release
Contributor
There was a problem hiding this comment.
Greptile Overview
Greptile Summary
This PR adds a forward-compatibility fix by explicitly including <cuda/std/utility> in type_utils.h. MatX currently uses cuda::std::as_const from this header but was relying on a transitive include from <cuda/std/tuple>. CCCL (CUDA C++ Core Libraries) will remove this transitive dependency in an upcoming release, which would break compilation. The explicit include ensures the code continues to work when downstream dependencies change their internal include structure. Additionally, the PR includes minor whitespace cleanup (trailing spaces and blank line formatting in comments), which has no functional impact but improves code hygiene.
Important Files Changed
| Filename | Score | Overview |
|---|---|---|
| include/matx/core/type_utils.h | 5/5 | Added explicit <cuda/std/utility> include to prevent future compilation breakage when CCCL removes transitive include; cosmetic whitespace cleanup in comments |
Confidence score: 5/5
- This PR is safe to merge with minimal risk and represents best-practice defensive programming
- Score reflects a straightforward header dependency fix with zero functional changes to logic; the explicit include is the correct solution for preventing future compilation failures
- No files require special attention; the single modified file contains only the necessary header include and cosmetic whitespace fixes
1 file reviewed, no comments
Collaborator
|
/build |
cliffburdick
approved these changes
Oct 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using
cuda::std::as_const. However, we relied on a transitive include from<cuda/std/tuple>that will be remove in a future release