Skip to content

Fix missing include of <cuda/std/utility>#1078

Merged
cliffburdick merged 1 commit intoNVIDIA:mainfrom
miscco:fix_missing_utility_include
Oct 27, 2025
Merged

Fix missing include of <cuda/std/utility>#1078
cliffburdick merged 1 commit intoNVIDIA:mainfrom
miscco:fix_missing_utility_include

Conversation

@miscco
Copy link
Contributor

@miscco miscco commented Oct 25, 2025

We are using cuda::std::as_const. However, we relied on a transitive include from <cuda/std/tuple> that will be remove in a future release

We are using `cuda::std::as_const`. However, we relied on a transitive include from `<cuda/std/tuple>` that will be remove in a future release
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

This PR adds a forward-compatibility fix by explicitly including <cuda/std/utility> in type_utils.h. MatX currently uses cuda::std::as_const from this header but was relying on a transitive include from <cuda/std/tuple>. CCCL (CUDA C++ Core Libraries) will remove this transitive dependency in an upcoming release, which would break compilation. The explicit include ensures the code continues to work when downstream dependencies change their internal include structure. Additionally, the PR includes minor whitespace cleanup (trailing spaces and blank line formatting in comments), which has no functional impact but improves code hygiene.

Important Files Changed

Filename Score Overview
include/matx/core/type_utils.h 5/5 Added explicit <cuda/std/utility> include to prevent future compilation breakage when CCCL removes transitive include; cosmetic whitespace cleanup in comments

Confidence score: 5/5

  • This PR is safe to merge with minimal risk and represents best-practice defensive programming
  • Score reflects a straightforward header dependency fix with zero functional changes to logic; the explicit include is the correct solution for preventing future compilation failures
  • No files require special attention; the single modified file contains only the necessary header include and cosmetic whitespace fixes

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@cliffburdick
Copy link
Collaborator

/build

@cliffburdick cliffburdick merged commit e875cff into NVIDIA:main Oct 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants