Most non-transform operators working with JIT#1094
Merged
cliffburdick merged 1 commit intomainfrom Nov 25, 2025
Merged
Conversation
Collaborator
Author
|
/build |
Contributor
Greptile Summary
Confidence Score: 3/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant CUDAJITExecutor
participant CapabilitySystem
participant KernelProvider
participant NVRTC
participant GPU
User->>CUDAJITExecutor: Exec(op)
CUDAJITExecutor->>CapabilitySystem: Check SUPPORTS_JIT capability
CapabilitySystem-->>CUDAJITExecutor: JIT supported
CUDAJITExecutor->>CapabilitySystem: Query GLOBAL_KERNEL capability
CapabilitySystem-->>CUDAJITExecutor: global_kernel flag
CUDAJITExecutor->>KernelProvider: create_kernel_provider(sizes, jit=true, global_kernel)
CUDAJITExecutor->>KernelProvider: find_best_launch_params(op, kernel_provider)
KernelProvider-->>CUDAJITExecutor: ept, shm_size, block_size, groups_per_block
CUDAJITExecutor->>CUDAJITExecutor: get_grid_dims(blocks, threads, sizes, ept)
CUDAJITExecutor->>NVRTC: nvrtc_compile_and_run(op, sizes, blocks, threads, ept, stride, shm_size)
NVRTC->>GPU: Launch JIT-compiled kernel
GPU-->>User: Results
|
Contributor
There was a problem hiding this comment.
91 files reviewed, 1 comment
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
ac0f1a2 to
7fad6f1
Compare
Contributor
There was a problem hiding this comment.
92 files reviewed, no comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
Collaborator
Author
Critical loop bug fixed. Please look again |
7fad6f1 to
ce9d5cb
Compare
Contributor
|
Skipped: This PR changes more files than the configured file change limit: ( |
Collaborator
Author
|
/build |
ce9d5cb to
b7239d9
Compare
Collaborator
Author
|
/build |
62bdbb4 to
dc08be7
Compare
dc08be7 to
8b9ae4b
Compare
Collaborator
Author
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converted most of the element-wise operators to have JIT support by adding all the capabilities and strings. ND operators still not working yet and need some investigation.
Other changes
GLOBAL_KERNELcapability that says whether it can operate as separate CTAs or notMATX_EN_JITis enabled along with the parameter sweeps. This can take a very long time and we'll have to figure out when to enable this.