Add MATX_EN_NVTIFF option

[tmartin-gh]

No description provided.

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[tmartin-gh]

/build

[greptile-apps]

Greptile Overview

Greptile Summary

Added MATX_EN_NVTIFF CMake option to make nvTiff support opt-in rather than automatically detected. Previously, CMake would always search for the nvtiff library; now it only searches when MATX_EN_NVTIFF is explicitly enabled.

Key Changes:

• Added MATX_EN_NVTIFF OFF option definition (defaults to OFF)
• Wrapped existing nvtiff detection logic in if (MATX_EN_NVTIFF) block
• Behavior now consistent with other optional libraries like MATX_EN_CUTENSOR, MATX_EN_FILEIO, etc.

Note: The found NVTIFF_LIBRARY variable is still not linked to the matx target (pre-existing issue). The nvtiff library appears to be header-only or linked elsewhere.

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The change is straightforward and follows established patterns for optional library support. It simply adds an option gate around existing nvtiff detection logic without modifying any functionality. The implementation is consistent with other optional features in the codebase (MATX_EN_CUTENSOR, MATX_EN_CUDSS, etc.). No logical errors or breaking changes introduced.
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
CMakeLists.txt	5/5	Added MATX_EN_NVTIFF option to gate nvTiff library detection, making it opt-in rather than automatic

Sequence Diagram

sequenceDiagram
    participant User as Build User
    participant CMake as CMake
    participant OptionCheck as Option Check
    participant Find as find_library
    participant MatX as MatX Target
    participant Code as TIFF Header
    
    User->>CMake: "Run CMake"
    CMake->>OptionCheck: "Check MATX_EN_NVTIFF"
    
    alt MATX_EN_NVTIFF is ON
        OptionCheck->>Find: "Search for nvtiff"
        alt library found
            Find-->>MatX: "Define MATX_ENABLE_NVTIFF"
            MatX->>Code: "Enable Tiff class"
        else library not found
            Find-->>CMake: "Log error message"
        end
    else MATX_EN_NVTIFF is OFF
        OptionCheck-->>CMake: "Skip nvtiff detection"
    end

Loading

[greptile-apps]

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[cliffburdick]

/build