Fixes for 32-bit builds. Tested w/ gcc 11.4 and CTK 12.9#1120
Merged
tbensonatl merged 1 commit intomainfrom Jan 16, 2026
Merged
Fixes for 32-bit builds. Tested w/ gcc 11.4 and CTK 12.9#1120tbensonatl merged 1 commit intomainfrom
tbensonatl merged 1 commit intomainfrom
Conversation
Adjust the make_tensor constraints to not match allocators to a ShapeType. Use MATX_INDEX_T_FMT in place of lld and explicitly convert indices in filter.cuh to index_t. Signed-off-by: Thomas Benson <tbenson@nvidia.com>
Contributor
Greptile SummaryFixed compilation issues for 32-bit builds by addressing type mismatches and format string incompatibilities.
All changes are well-targeted fixes for 32-bit compatibility without affecting 64-bit builds or runtime behavior. Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User as User Code
participant MT as make_tensor/make_tensor_p
participant Filter as RecursiveFilter Kernel
participant Print as printf
Note over User,Print: 32-bit Build Compilation Flow
User->>MT: Call make_tensor(data, shape)
Note over MT: Before: ShapeType could match allocators
Note over MT: After: is_tuple_c constraint ensures<br/>ShapeType is a tuple
MT-->>User: Return tensor_t
User->>Filter: Launch kernel with tensor
Note over Filter: Loop counters changed from<br/>uint32_t to index_t
Filter->>Filter: Access d_in/d_out with<br/>static_cast<index_t>(blockIdx.y)
Note over Filter: Explicit casts prevent<br/>implicit conversion warnings
Filter-->>User: Kernel complete
User->>Print: printf with index value
Note over Print: Format string uses<br/>MATX_INDEX_T_FMT macro
Note over Print: 32-bit: "d", 64-bit: "lld"
Print-->>User: Correct output
|
Collaborator
|
/build |
Collaborator
|
Fixes #1117 |
cliffburdick
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust the make_tensor constraints to not match allocators to a ShapeType. Use MATX_INDEX_T_FMT in place of lld and explicitly convert indices in filter.cuh to index_t.