Skip to content

Add sparse factory method tests#871

Merged
cliffburdick merged 3 commits intoNVIDIA:mainfrom
aartbik:buk
Feb 7, 2025
Merged

Add sparse factory method tests#871
cliffburdick merged 3 commits intoNVIDIA:mainfrom
aartbik:buk

Conversation

@aartbik
Copy link
Copy Markdown
Collaborator

@aartbik aartbik commented Feb 6, 2025

No description provided.

Comment thread test/CMakeLists.txt Outdated
Comment thread test/sparse/Sparse.cu
Copy link
Copy Markdown
Collaborator

@cliffburdick cliffburdick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "Sparse.cu" is too generic of a name if this is going in its own folder. If it's just going to be one large file it can go in 00_tensor with that name. If you plan on having a lot of separate tests, This might be "Basic.cu" or something.

@aartbik aartbik requested a review from cliffburdick February 6, 2025 22:01
@aartbik
Copy link
Copy Markdown
Collaborator Author

aartbik commented Feb 6, 2025

I think "Sparse.cu" is too generic of a name if this is going in its own folder. If it's just going to be one large file it can go in 00_tensor with that name. If you plan on having a lot of separate tests, This might be "Basic.cu" or something.

Renamed.

@cliffburdick
Copy link
Copy Markdown
Collaborator

/build

@cliffburdick cliffburdick merged commit 252dc03 into NVIDIA:main Feb 7, 2025
@cliffburdick cliffburdick deleted the buk branch February 7, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants