Skip to content

[DEV] Update emerging optimizers#2261

Merged
FDecaYed merged 3 commits intoNVIDIA:devfrom
skyw:update-emerging-optimizers
Nov 18, 2025
Merged

[DEV] Update emerging optimizers#2261
FDecaYed merged 3 commits intoNVIDIA:devfrom
skyw:update-emerging-optimizers

Conversation

@skyw
Copy link
Contributor

@skyw skyw commented Nov 14, 2025

What does this PR do ?

added into main PR #2241

Bump emerging-optimizer dependency to v0.1.0

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share discuss a design-doc with the team.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@skyw skyw requested a review from FDecaYed November 14, 2025 23:45
@skyw skyw requested review from a team as code owners November 14, 2025 23:46
@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 14, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@skyw skyw changed the base branch from main to dev November 14, 2025 23:46
@skyw skyw requested a review from a team as a code owner November 14, 2025 23:46
@skyw
Copy link
Contributor Author

skyw commented Nov 14, 2025

/ok to test a6b7a6a

@skyw
Copy link
Contributor Author

skyw commented Nov 17, 2025

/ok to test 3062f72

Copy link
Contributor

@FDecaYed FDecaYed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. missing PR to main, cherry-picked into umbrella muon PR for main #2241

@FDecaYed
Copy link
Contributor

/ok to test 688c272

skyw added 3 commits November 18, 2025 17:14
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
@FDecaYed
Copy link
Contributor

/ok to test e2bb6c3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev branch Dev branch related issues and development Final Review PR is in the "final review" stage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants