Skip to content

[Dev] Use the latest Hybrid-EP#2424

Merged
yaox12 merged 4 commits intoNVIDIA:devfrom
Autumn1998:optimize_hybrid_ep
Dec 12, 2025
Merged

[Dev] Use the latest Hybrid-EP#2424
yaox12 merged 4 commits intoNVIDIA:devfrom
Autumn1998:optimize_hybrid_ep

Conversation

@Autumn1998
Copy link
Contributor

@Autumn1998 Autumn1998 commented Nov 28, 2025

What does this PR do ?

To make use of the latest EP.
In this version, the 2 synchronizations are grouped into 1, and remove num_dispatched_tokens
Corresponding PR in dev branch: #2479

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@Autumn1998 Autumn1998 requested review from a team as code owners November 28, 2025 08:51
@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 28, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Autumn1998 Autumn1998 self-assigned this Nov 28, 2025
@Autumn1998 Autumn1998 marked this pull request as draft November 28, 2025 08:52
@Autumn1998 Autumn1998 mentioned this pull request Dec 3, 2025
6 tasks
@Autumn1998 Autumn1998 added the dev branch Dev branch related issues and development label Dec 3, 2025
@Autumn1998 Autumn1998 marked this pull request as ready for review December 3, 2025 08:51
@Autumn1998 Autumn1998 requested a review from a team as a code owner December 3, 2025 08:51
@Autumn1998
Copy link
Contributor Author

/ok to test 0d84ea4

@Autumn1998
Copy link
Contributor Author

/ok to test f2a4eab

@Autumn1998
Copy link
Contributor Author

/ok to test 942825f

@Autumn1998
Copy link
Contributor Author

/ok to test 7b3f1e5

@yaox12 yaox12 enabled auto-merge December 10, 2025 03:00
@yaox12 yaox12 added Final Review PR is in the "final review" stage and removed Expert Review Apply this label to indicate that your PR is ready for expert review. labels Dec 10, 2025
@Autumn1998
Copy link
Contributor Author

/ok to test b74d869

@Autumn1998
Copy link
Contributor Author

/ok to test 5be060c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev branch Dev branch related issues and development Final Review PR is in the "final review" stage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants