Skip to content

[Dev] Fix ep overlap missing final layernorm#2691

Merged
Wohox merged 5 commits intoNVIDIA:devfrom
Wohox:pingtian/fix_ep_overlap_missing_final_layernorm-dev
Dec 23, 2025
Merged

[Dev] Fix ep overlap missing final layernorm#2691
Wohox merged 5 commits intoNVIDIA:devfrom
Wohox:pingtian/fix_ep_overlap_missing_final_layernorm-dev

Conversation

@Wohox
Copy link
Contributor

@Wohox Wohox commented Dec 17, 2025

What does this PR do ?

This PR fixes the missing final layernorm bug when below conditions are met:

  • enable ep overlap with VPP
  • number of mtp layers is 0
  • last VPP rank only contain LM loss
    For example: PP layout E(tt|)*3L
Screenshot 2025-12-17 at 17 27 51

Note: Main branch MR: #2136

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@Wohox Wohox requested review from a team as code owners December 17, 2025 09:35
@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 17, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Wohox
Copy link
Contributor Author

Wohox commented Dec 17, 2025

cc @hxbai

@Wohox Wohox changed the title [Draft][Dev] Fix ep overlap missing final layernorm [Dev] Fix ep overlap missing final layernorm Dec 19, 2025
@Wohox Wohox force-pushed the pingtian/fix_ep_overlap_missing_final_layernorm-dev branch from 963f8f0 to 65c6919 Compare December 19, 2025 05:49
@Wohox
Copy link
Contributor Author

Wohox commented Dec 19, 2025

/ok to test 65c6919

@BestJuly
Copy link
Contributor

LGTM. Please fix the linting and the copyright check.

@Wohox
Copy link
Contributor Author

Wohox commented Dec 19, 2025

/ok to test 3e78312

@Wohox
Copy link
Contributor Author

Wohox commented Dec 21, 2025

/ok to test ba38e01

@Wohox Wohox enabled auto-merge December 23, 2025 02:02
@Wohox
Copy link
Contributor Author

Wohox commented Dec 23, 2025

/ok to test 66658e8

@Wohox Wohox added bug Something isn't working dev branch Dev branch related issues and development labels Dec 23, 2025
@Wohox Wohox added the Expert Review Apply this label to indicate that your PR is ready for expert review. label Dec 23, 2025
@Wohox Wohox added this pull request to the merge queue Dec 23, 2025
Merged via the queue into NVIDIA:dev with commit 46b5505 Dec 23, 2025
44 of 46 checks passed
@Wohox Wohox deleted the pingtian/fix_ep_overlap_missing_final_layernorm-dev branch December 23, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dev branch Dev branch related issues and development Expert Review Apply this label to indicate that your PR is ready for expert review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants