Skip to content

[Dev] Disable ep overlap memory optimization#2750

Merged
FDecaYed merged 1 commit intoNVIDIA:devfrom
Wohox:pingtian/disable_ep_ovlp_memory_optimization_dev
Dec 30, 2025
Merged

[Dev] Disable ep overlap memory optimization#2750
FDecaYed merged 1 commit intoNVIDIA:devfrom
Wohox:pingtian/disable_ep_ovlp_memory_optimization_dev

Conversation

@Wohox
Copy link
Contributor

@Wohox Wohox commented Dec 24, 2025

What does this PR do ?

This MR disables dgrad memory optimization for ep overlap in #2201 since it's causing nemo CI failure.

MR for main branch #2236

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@Wohox Wohox requested review from a team as code owners December 24, 2025 05:53
@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 24, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot requested a review from Phlip79 December 24, 2025 05:53
@Wohox Wohox added bug Something isn't working Expert Review Apply this label to indicate that your PR is ready for expert review. dev branch Dev branch related issues and development labels Dec 24, 2025
@Wohox
Copy link
Contributor Author

Wohox commented Dec 24, 2025

/ok to test 3ec65c0

@ko3n1g ko3n1g added this to the Core 0.16 milestone Dec 24, 2025
@Wohox Wohox force-pushed the pingtian/disable_ep_ovlp_memory_optimization_dev branch 2 times, most recently from ded7951 to 1dc655d Compare December 24, 2025 06:33
@Wohox
Copy link
Contributor Author

Wohox commented Dec 24, 2025

/ok to test 1dc655d

Copy link
Contributor

@ko3n1g ko3n1g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

Copy link
Contributor

@FDecaYed FDecaYed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FDecaYed FDecaYed added this pull request to the merge queue Dec 30, 2025
Merged via the queue into NVIDIA:dev with commit 9885ddb Dec 30, 2025
46 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dev branch Dev branch related issues and development Expert Review Apply this label to indicate that your PR is ready for expert review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants