Add Claude Code plugin marketplace for ModelOpt agent skills#1141
Add Claude Code plugin marketplace for ModelOpt agent skills#1141
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughAdded two new Claude plugin configuration files: a marketplace manifest for Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.claude-plugin/marketplace.json:
- Around line 8-14: The plugin manifest declares "modelopt-agent" with source
"./.claude/skills" but the skills directory only contains plugin metadata and no
executable skill implementations, so commands like /modelopt-agent:* won't be
discovered; add actual skill files (e.g., TypeScript/JavaScript/Python handlers)
into the "./.claude/skills" folder that export the declared commands and
handlers referenced by the plugin manifest (ensure function/command names and
routes match the manifest and plugin.json), include proper entry points and
registration code so the runtime can discover commands, and update the package
manifest if needed to reference the new skill files.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 86e71c35-d8e4-4a64-b5fa-9358f048d2f0
📒 Files selected for processing (2)
.claude-plugin/marketplace.json.claude/skills/.claude-plugin/plugin.json
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1141 +/- ##
==========================================
- Coverage 74.76% 74.76% -0.01%
==========================================
Files 351 351
Lines 40072 40072
==========================================
- Hits 29961 29958 -3
- Misses 10111 10114 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Edwardf0t1
left a comment
There was a problem hiding this comment.
I think it would be better to add this after we’ve finished polishing the skills within our team.
Signed-off-by: Kai Xu <kaix@nvidia.com>
d7e59cc to
3a33af4
Compare
What does this PR do?
Type of change: ?
New feature. Add Claude Code plugin marketplace manifest so ModelOpt agent skills can be discovered and installed with a single command.
Usage
Testing
Before your PR is "Ready for review"
Make sure you read and follow Contributor guidelines and your commits are signed (
git commit -s -S).Make sure you read and follow the Security Best Practices (e.g. avoiding hardcoded
trust_remote_code=True,torch.load(..., weights_only=False),pickle, etc.).CONTRIBUTING.md: ✅ / ❌ / N/AAdditional Information
Summary by CodeRabbit