-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix(security): shell-quote sandboxName in exec and DNS proxy commands #1392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
brandonpelfrey
merged 3 commits into
NVIDIA:main
from
latenighthackathon:fix/shellquote-sandbox-name
Apr 7, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
e192715
fix(security): shell-quote sandboxName in exec and DNS proxy commands
latenighthackathon 7f24f7b
test: use block-wise regex to catch multiline run/runCapture calls
latenighthackathon 361bc58
test: add SPDX license header to shellquote-sandbox test
latenighthackathon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| // SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| // Verify shellQuote is applied to sandboxName in shell commands | ||
| import fs from "fs"; | ||
| import path from "path"; | ||
| import { describe, it, expect } from "vitest"; | ||
|
|
||
| describe("sandboxName shell quoting in onboard.js", () => { | ||
| const src = fs.readFileSync( | ||
| path.join(import.meta.dirname, "..", "bin", "lib", "onboard.js"), | ||
| "utf-8", | ||
| ); | ||
|
|
||
| it("quotes sandboxName in openshell sandbox exec command", () => { | ||
| expect(src).toMatch(/openshell sandbox exec \$\{shellQuote\(sandboxName\)\}/); | ||
| }); | ||
|
|
||
| it("quotes sandboxName in setup-dns-proxy.sh command", () => { | ||
| expect(src).toMatch( | ||
| /setup-dns-proxy\.sh.*\$\{shellQuote\(GATEWAY_NAME\)\}.*\$\{shellQuote\(sandboxName\)\}/, | ||
| ); | ||
| }); | ||
|
|
||
| it("does not have unquoted sandboxName in runCapture or run calls", () => { | ||
| // Match run()/runCapture() calls that span multiple lines and contain | ||
| // template literals, so multiline invocations are not missed. | ||
| const callPattern = /\b(run|runCapture)\s*\(\s*`([^`]*)`/g; | ||
| const violations = []; | ||
| let match; | ||
| while ((match = callPattern.exec(src)) !== null) { | ||
| const template = match[2]; | ||
| if ( | ||
| template.includes("${sandboxName}") && | ||
| !template.includes("shellQuote(sandboxName)") | ||
| ) { | ||
| const line = src.slice(0, match.index).split("\n").length; | ||
| violations.push(`Line ${line}: ${match[0].slice(0, 120).trim()}`); | ||
| } | ||
| } | ||
| expect(violations).toEqual([]); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for missing this before. SPDX header is missing. Should be automatically applied by the pre-commit hook.