fix(sandbox): export HTTP_PROXY/HTTPS_PROXY/NO_PROXY so Node.js routes through OpenShell egress proxy (fixes #626)

[nanookclaw]

Problem

Web search tools (Brave, Gemini, Perplexity) fail inside the NemoClaw sandbox with getaddrinfo EAI_AGAIN regardless of what is added to the network policy. This was reported in #626.

Root cause: Node.js (undici/node:fetch) resolves DNS locally before opening the CONNECT tunnel to the OpenShell egress proxy at 10.200.0.1:3128. The sandbox network namespace has no DNS resolver configured, so local resolution always fails.

curl does not have this problem — it sends the full hostname to the proxy and lets the proxy resolve DNS. Node.js requires the HTTP_PROXY / HTTPS_PROXY env var to do the same.

Fix

Export HTTP_PROXY, HTTPS_PROXY, and NO_PROXY in nemoclaw-start.sh before openclaw gateway is launched. This causes Node.js/undici to route all outbound HTTPS through the OpenShell proxy, which handles DNS resolution — matching the behaviour users already see with curl.

PROXY_HOST="${NEMOCLAW_PROXY_HOST:-10.200.0.1}"
PROXY_PORT="${NEMOCLAW_PROXY_PORT:-3128}"
export HTTP_PROXY="http://${PROXY_HOST}:${PROXY_PORT}"
export HTTPS_PROXY="http://${PROXY_HOST}:${PROXY_PORT}"
export NO_PROXY="localhost,127.0.0.1,::1,inference.local,10.200.0.0/16"

NO_PROXY excludes loopback, inference.local, and the 10.200.0.0/16 OpenShell virtual network so internal gateway calls stay on the fast path and are not routed through the proxy.

Overrides: NEMOCLAW_PROXY_HOST and NEMOCLAW_PROXY_PORT allow users to adjust the proxy address if the OpenShell gateway IP changes in a future release.

Tests

Added 6 tests to test/service-env.test.js verifying:

• Default proxy URLs point at 10.200.0.1:3128
• NEMOCLAW_PROXY_HOST override works
• NEMOCLAW_PROXY_PORT override works
• NO_PROXY excludes loopback and inference.local
• NO_PROXY excludes the OpenShell virtual network range

All 17 tests in service-env.test.js pass. The one pre-existing failure in install-preflight.test.js (can run via stdin without a sibling runtime.sh file) is present on main before this change and is unrelated.

Closes #626

Summary by CodeRabbit

• New Features

  • Runtime proxy support with configurable host/port; default proxy is 10.200.0.1:3128. NO_PROXY bypasses localhost, 127.0.0.1, ::1, inference.local, and the gateway IP 10.200.0.1.
  • Proxy settings are exported at startup and, when possible, persisted for login shells so interactive sessions inherit them.

• Tests

  • Added tests covering proxy defaults, host/port overrides, and creation of the login-shell proxy snippet.

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds outbound proxy configuration to scripts/nemoclaw-start.sh: computes PROXY_HOST/PROXY_PORT from NEMOCLAW_PROXY_HOST/NEMOCLAW_PROXY_PORT, exports HTTP_PROXY, HTTPS_PROXY, and NO_PROXY, and conditionally writes /etc/profile.d/nemoclaw-proxy.sh. Adds tests that extract and validate the proxy snippet's produced environment variables and profile.d writer behavior.

Changes

Cohort / File(s)	Summary
Startup script scripts/nemoclaw-start.sh	Add computation of PROXY_HOST/PROXY_PORT from NEMOCLAW_PROXY_HOST/NEMOCLAW_PROXY_PORT, export HTTP_PROXY/HTTPS_PROXY/NO_PROXY, and conditionally write /etc/profile.d/nemoclaw-proxy.sh to re-export proxies on login. Also minor whitespace/log-redirection tweaks and adjusted multi-line token capture.
Tests test/service-env.test.js	New test suite "proxy environment variables (issue #626)" that extracts the proxy block from the start script, runs it in a temporary wrapper with controlled env, and asserts default and overridden HTTP_PROXY/HTTPS_PROXY values and NO_PROXY contents (includes localhost, 127.0.0.1, ::1, inference.local, and the gateway IP 10.200.0.1). Also tests writing of the nemoclaw-proxy.sh snippet into a profile.d-like directory.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Poem

🐰 I hopped through shells and set the trail,
Exports in place to guide each sail,
A tiny script to show the way,
Tests to prove we won the day,
🥕 Proxy paths—now off I play!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: exporting proxy environment variables so Node.js routes through OpenShell proxy, and correctly references the issue being fixed.
Linked Issues check	✅ Passed	The PR implements the chosen solution from issue #626 by exporting HTTP_PROXY/HTTPS_PROXY/NO_PROXY environment variables and adding /etc/profile.d script writer to ensure Node.js routes through the OpenShell proxy.
Out of Scope Changes check	✅ Passed	All changes are in-scope: proxy environment variable setup in nemoclaw-start.sh and comprehensive tests in service-env.test.js directly address the issue #626 requirements.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

test/service-env.test.js (1)

107-136: Test duplicates script logic rather than sourcing the actual implementation.

The extractProxyVars helper embeds a copy of the proxy variable logic from nemoclaw-start.sh. If the shell script is modified (e.g., different defaults, additional proxy vars), these tests will still pass but won't catch the regression.

Consider sourcing or extracting the relevant lines directly from scripts/nemoclaw-start.sh to ensure the test validates the actual implementation. Alternatively, add a comment noting this intentional duplication so future maintainers remember to update both locations.

🔧 Option: Add a warning comment about the duplication

     function extractProxyVars(env = {}) {
-      // Write the proxy-variable snippet from nemoclaw-start.sh to a temp script
-      // and execute it so that bash variable assignments and expansions work
-      // correctly without interference from JSON.stringify quote-escaping.
+      // IMPORTANT: This script mirrors the proxy-variable logic from
+      // scripts/nemoclaw-start.sh. If you update the proxy configuration
+      // there, update this test helper as well to keep them in sync.
       const script = [

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/service-env.test.js` around lines 107 - 136, The test helper
extractProxyVars duplicates the proxy logic instead of sourcing
scripts/nemoclaw-start.sh; update extractProxyVars to read and source the real
script (or extract the proxy-related lines) so tests reflect the actual
implementation—e.g., have extractProxyVars locate scripts/nemoclaw-start.sh,
write a short temp wrapper that sources that file and echoes
HTTP_PROXY/HTTPS_PROXY/NO_PROXY, then execFileSync that wrapper with the
provided env; if you prefer not to change behavior, add a clear comment above
extractProxyVars stating it intentionally duplicates nemoclaw-start.sh and must
be kept in sync with that file.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@scripts/nemoclaw-start.sh`:
- Around line 148-154: The NO_PROXY value currently contains a CIDR entry
("10.200.0.0/16") which EnvHttpProxyAgent (undici) won't match; update the
NO_PROXY assignment to remove the CIDR or replace it with explicit hosts/IPs
that should bypass the proxy (e.g., list the gateway host 10.200.0.1 and any
other specific IPs or hostnames used on the virtual network), ensuring the
environment variable set in the scripts/nemoclaw-start.sh (NO_PROXY) only
contains exact hostnames, domain suffixes, or individual IPs so
EnvHttpProxyAgent will correctly bypass the proxy for internal addresses
referenced by code that uses EnvHttpProxyAgent.

---

Nitpick comments:
In `@test/service-env.test.js`:
- Around line 107-136: The test helper extractProxyVars duplicates the proxy
logic instead of sourcing scripts/nemoclaw-start.sh; update extractProxyVars to
read and source the real script (or extract the proxy-related lines) so tests
reflect the actual implementation—e.g., have extractProxyVars locate
scripts/nemoclaw-start.sh, write a short temp wrapper that sources that file and
echoes HTTP_PROXY/HTTPS_PROXY/NO_PROXY, then execFileSync that wrapper with the
provided env; if you prefer not to change behavior, add a clear comment above
extractProxyVars stating it intentionally duplicates nemoclaw-start.sh and must
be kept in sync with that file.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a807432e-cbfe-498e-b1d1-8f0961099749

📥 Commits

Reviewing files that changed from the base of the PR and between c55a309 and 88e573a.

📒 Files selected for processing (2)

• scripts/nemoclaw-start.sh
• test/service-env.test.js

[nanookclaw]

Good catch from CodeRabbit — addressed in 623d878.

extractProxyVars now sources the proxy block directly from scripts/nemoclaw-start.sh using sed extraction rather than duplicating the logic. The wrapper runs the actual shell lines and echoes the three variables. If the script's defaults or variable names change, the tests will catch the regression.

All 17 tests still pass.

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@test/service-env.test.js`:
- Around line 167-173: The test "NO_PROXY excludes loopback and inference.local"
is missing an assertion for the IPv6 loopback; update the test that calls
extractProxyVars() and checks vars.NO_PROXY to also assert the presence of "::1"
(e.g., add expect(noProxy).toContain("::1")). Keep the existing logic that
splits NO_PROXY and retains assertions for "localhost", "127.0.0.1", and
"inference.local" so the test verifies all expected loopback entries.
- Around line 116-121: The sed extraction into proxyBlock (via execFileSync with
scriptPath) may return an empty string if the pattern doesn't match; add a guard
after obtaining proxyBlock that checks proxyBlock.trim() and throws a clear
Error like "Failed to extract proxy configuration from nemoclaw-start.sh" so
tests fail fast and with a descriptive message; update the test around the
execFileSync call (proxyBlock variable) to validate extraction before using the
proxy environment in subsequent steps.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 21690e2b-003a-44d8-86c7-ed3e2563a4ca

📥 Commits

Reviewing files that changed from the base of the PR and between 88e573a and 623d878.

📒 Files selected for processing (1)

• test/service-env.test.js

[nanookclaw]

Addressed the three CodeRabbit review comments (c81cb4f):

1. CIDR in NO_PROXY (Major): Replaced 10.200.0.0/16 with 10.200.0.1. Node.js undici EnvHttpProxyAgent matches NO_PROXY entries as exact hostnames/domain suffixes, not CIDR ranges — the CIDR entry was silently treated as a literal hostname string and matched nothing.

2. Empty proxyBlock guard (Minor): extractProxyVars() now throws with a clear message if the sed extraction returns empty, so script-format regressions surface immediately instead of producing silent empty-env failures.

3. ::1 test coverage (Minor): Added assertion for IPv6 loopback ::1 in the loopback exclusion test, matching the entry already present in the script.

All 17 tests pass.

[kjw3]

Retested this on a scrubbed Linux VM to make sure the earlier result was not test error. The outcome is the same.

What we verified:

• the PR shell block itself behaves correctly on the host
• defaults resolve to:
  • HTTP_PROXY=http://10.200.0.1:3128
  • HTTPS_PROXY=http://10.200.0.1:3128
  • NO_PROXY=localhost,127.0.0.1,::1,inference.local,10.200.0.1
• host/port overrides also work correctly for HTTP_PROXY / HTTPS_PROXY
• after nemoclaw onboard and nemoclaw my-assistant connect, inside the live sandbox runtime we still see:
  • HTTP_PROXY=http://10.200.0.1:3128
  • HTTPS_PROXY=http://10.200.0.1:3128
  • NO_PROXY=127.0.0.1,localhost,::1
• Node no longer fails with getaddrinfo EAI_AGAIN; it reaches the proxy and fails later with Proxy response (403) !== 200 when HTTP Tunneling, which is good evidence that the proxy routing part is working

So the remaining blocker is specifically NO_PROXY propagation:

• the startup script exports inference.local,10.200.0.1
• but those entries are missing in the actual sandbox runtime env

Please follow up with a fix or explanation for that mismatch. The re-review condition is that inside the running sandbox, env shows the full expected NO_PROXY value from the script, not the truncated loopback-only value.

Once that is fixed, I’m happy to re-review.

[nanookclaw]

Thanks for the detailed re-test, @kjw3 — this pinpoints exactly what's happening.

Root cause: OpenShell injects NO_PROXY=127.0.0.1,localhost,::1 when establishing the sandbox connect session. This overwrites the value set in nemoclaw-start.sh for the gateway process, but any shell opened via connect after that point gets the truncated loopback-only value.

Fix (b820c9c): After exporting the proxy vars in nemoclaw-start.sh, write /etc/profile.d/nemoclaw-proxy.sh with the full NO_PROXY value. /etc/profile.d/ snippets are sourced by bash after OpenShell's injection on every login shell — so connected sessions see inference.local and 10.200.0.1 in NO_PROXY.

The write is guarded by [ -d /etc/profile.d ] so it's a no-op in environments where the directory doesn't exist.

Test added: writes proxy snippet to a profile.d directory when it exists — verifies the snippet is created with all expected entries. All 18 tests pass.

If you can re-test with the updated branch, the expected sandbox env output should now show:

HTTP_PROXY=http://10.200.0.1:3128
HTTPS_PROXY=http://10.200.0.1:3128
NO_PROXY=localhost,127.0.0.1,::1,inference.local,10.200.0.1

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@scripts/nemoclaw-start.sh`:
- Line 154: The NO_PROXY export currently hardcodes 10.200.0.1 which breaks
custom proxy host overrides; update the NO_PROXY value to include the
configurable variable (use ${PROXY_HOST} or ${NEMOCLAW_PROXY_HOST} consistent
with how HTTP_PROXY/HTTPS_PROXY are set) so the proxy host is bypassed
correctly, and make the same replacement inside the heredoc where the hardcoded
10.200.0.1 is used; ensure you reference the NO_PROXY export and the heredoc
occurrence when making the edits.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2dbd4761-0e80-4739-abd3-3990ec96f07a

📥 Commits

Reviewing files that changed from the base of the PR and between 623d878 and b820c9c.

📒 Files selected for processing (2)

• scripts/nemoclaw-start.sh
• test/service-env.test.js

🚧 Files skipped from review as they are similar to previous changes (1)

• test/service-env.test.js

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

NO_PROXY hardcodes 10.200.0.1 instead of using ${PROXY_HOST}.

Lines 154 and 166 hardcode 10.200.0.1 in NO_PROXY, while HTTP_PROXY and HTTPS_PROXY use the configurable ${PROXY_HOST}. If a user overrides NEMOCLAW_PROXY_HOST to a different IP, the proxy host won't be bypassed, potentially causing requests to the proxy to be routed through itself.

🐛 Proposed fix for consistency

-export NO_PROXY="localhost,127.0.0.1,::1,inference.local,10.200.0.1"
+export NO_PROXY="localhost,127.0.0.1,::1,inference.local,${PROXY_HOST}"

And in the heredoc (line 166):

-export NO_PROXY="localhost,127.0.0.1,::1,inference.local,10.200.0.1"
+export NO_PROXY="localhost,127.0.0.1,::1,inference.local,${PROXY_HOST}"

Also applies to: 166-166

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@scripts/nemoclaw-start.sh` at line 154, The NO_PROXY export currently
hardcodes 10.200.0.1 which breaks custom proxy host overrides; update the
NO_PROXY value to include the configurable variable (use ${PROXY_HOST} or
${NEMOCLAW_PROXY_HOST} consistent with how HTTP_PROXY/HTTPS_PROXY are set) so
the proxy host is bypassed correctly, and make the same replacement inside the
heredoc where the hardcoded 10.200.0.1 is used; ensure you reference the
NO_PROXY export and the heredoc occurrence when making the edits.

[kjw3]

Thanks for pushing the original direction here.

The later follow-up work on #1025 confirmed that your core diagnosis was right:

• the proxy env needs to be exported in nemoclaw-start.sh
• NO_PROXY needs the full bypass list, including inference.local and the gateway IP
• the real fix has to account for what happens again on reconnect, not just initial container startup

The part that turned out to need more iteration was the persistence/reconnect mechanism, not the direction of the fix itself.

So thank you for getting the problem framed correctly and moving this line of work forward.

[kjw3]

Closing this as superseded by the later follow-through in #1025. The original direction here was correct and materially guided the fix line, but the reconnect/persistence mechanism needed more iteration before it worked end to end.