Skip to content

fix(build): match only semver tags in git_version()#835

Closed
Ai-chan-0411 wants to merge 1 commit intoNVIDIA:mainfrom
Ai-chan-0411:fix/version-tag-match
Closed

fix(build): match only semver tags in git_version()#835
Ai-chan-0411 wants to merge 1 commit intoNVIDIA:mainfrom
Ai-chan-0411:fix/version-tag-match

Conversation

@Ai-chan-0411
Copy link
Copy Markdown

Summary

  • Fix git_version() in build.rs to use --match "v[0-9]*" instead of --match "v*" so that non-version tags like vm-dev are excluded from git describe output

Closes #832

Root cause

git describe --tags --long --match "v*" matches both v0.0.28 and vm-dev since both start with v. When vm-dev is on a more recent commit, git picks it, resulting in the version string m-dev after the v prefix is stripped.

Fix

Change the glob pattern from v* to v[0-9]* so only tags that start with v followed by a digit (i.e. semantic version tags like v0.0.28) are matched.

Test plan

  • Verify git describe --tags --long --match "v[0-9]*" skips vm-dev and returns the correct semver tag
  • Build locally and confirm openshell --version shows the expected version

Change --match pattern from "v*" to "v[0-9]*" so that
git describe only considers semantic version tags (e.g. v0.0.28)
and skips non-version tags like vm-dev.

Closes NVIDIA#832
@Ai-chan-0411 Ai-chan-0411 requested a review from a team as a code owner April 14, 2026 21:40
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Apr 14, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions
Copy link
Copy Markdown

Thank you for your interest in contributing to OpenShell, @Ai-chan-0411.

This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer.

To get vouched:

  1. Open a Vouch Request discussion.
  2. Describe what you want to change and why.
  3. Write in your own words — do not have an AI generate the request.
  4. A maintainer will comment /vouch if approved.
  5. Once vouched, open a new PR (preferred) or reopen this one after a few minutes.

See CONTRIBUTING.md for details.

@github-actions
Copy link
Copy Markdown

Thank you for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:


I have read the DCO document and I hereby sign the DCO.


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot.

@github-actions github-actions bot closed this Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The v0.0.28 release binary identifies as m-dev instead of 0.0.28

1 participant