Repository navigation
Conversation
Fixes NVIDIA#1021 Refs 777genius/universal-agent-plugins-registry#411 Signed-off-by: iliya <iliyazelenkog@gmail.com>
777genius
marked this pull request as ready for review
November 4, 2026 23:21
yashrajp22
requested changes
Nov 5, 2026
yashrajp22
left a comment
Collaborator
There was a problem hiding this comment.
I completed an independent source review and adjudicated Greptile's completed review of 1cd5a1d to c47f9fa. The new matcher has a resource-bounds issue, and one regression assertion can accept the wrong reference record.
This is a source-only review: I have not run tests, builds, scans, installed-wheel checks, corpus verification, or provider calls. The backtracking finding is based on source analysis; no runtime timing measurements or full verification are claimed.
Refs NVIDIA#1021 Refs 777genius/universal-agent-plugins-registry#411 Signed-off-by: iliya <iliyazelenkog@gmail.com>
Author
|
Thank you, ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An isolated JSON field such as
"VERSION": "1.0.0",is extracted as a local file reference. This creates a spurious missing-reference record for JSON metadata, including the example inasc-workflow/SKILL.mddescribed in #1021.Change
Exclude only the version value span of a complete uppercase JSON
VERSIONfield line containing a three-component numeric version and an optional trailing comma. Other keys, malformed versions, explicit Markdown destinations, numeric filenames, and interpreter script operands retain their existing reference behavior.This changes extraction only. It does not change missing-reference reporting policy, coverage limits, path containment checks, or safety recommendations directly.
Validation
make format,make lint, andmake format-checkpass.make testunit phase: 19,634 passed, 24 skipped, 4 xfailed, 2 failed. Both failures use the hardcoded/nonexistent/path/xyz; this host denies access to/nonexistent, producingPermissionErrorrather than the expected missing-path error. They reproduce on the unchanged upstream base.make test-integrationseparately becausemake teststopped at the unit failures: 248 passed, 5 skipped, 1 failed. The remaining failure has the same/nonexistentcause and also reproduces on the unchanged base.Related: #524 / #525 concern YAML frontmatter. This contribution is limited to JSON field classification. A separate v2.13.3 backport is available in the fork; no Registry scanner or profile is changed by this PR.
Fixes #1021
Refs 777genius/universal-agent-plugins-registry#411
Upstream GitHub CI passed all six jobs for commit
c47f9fa831a7221645234f4adbdbf3446248bbf3: changes, lint, test-unit, OpenCode TypeScript Tests, DCO Check, and docker-smoke. Run: https://github.com/NVIDIA/SkillSpector/actions/runs/41914583925.