Skip to content

[https://nvbugs/5701445][chore] unwaive test.#9949

Merged
yuxianq merged 12 commits intoNVIDIA:mainfrom
yuxianq:unwaive-ds-fp8-h100
Dec 22, 2025
Merged

[https://nvbugs/5701445][chore] unwaive test.#9949
yuxianq merged 12 commits intoNVIDIA:mainfrom
yuxianq:unwaive-ds-fp8-h100

Conversation

@yuxianq
Copy link
Collaborator

@yuxianq yuxianq commented Dec 12, 2025

Summary by CodeRabbit

  • Tests
    • Updated test skip configurations for model variant testing.

Note: This release includes internal testing infrastructure updates with no user-facing changes.

✏️ Tip: You can customize this high-level summary in your review settings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 12, 2025

/bot run --disable-fail-fast

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 12, 2025

📝 Walkthrough

Walkthrough

A skip entry in the test waives list is updated, removing a skipped configuration for DeepSeekV3Lite FP8 test and adding a different skipped configuration for DeepSeekV3Lite NvFP4 test. No runtime code or control flow is altered.

Changes

Cohort / File(s) Change Summary
Test skip configuration
tests/integration/test_lists/waives.txt
Removed skip entry for test_fp8_block_scales_4gpus and added skip entry for test_nvfp4_4gpus, both for DeepSeekV3Lite test case

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is incomplete and contains only a template with no actual content. Required sections like Description, Test Coverage are empty. Fill in the Description section explaining why the test is being unwaived, and specify in Test Coverage which tests validate this change.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly indicates the PR is removing a test waiver entry for DeepSeekV3Lite, which aligns with the changeset that replaces one skip entry with another in the waives.txt file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28016 [ run ] triggered by Bot. Commit: 00f4a27

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28016 [ run ] completed with state SUCCESS. Commit: 00f4a27
/LLM/main/L0_MergeRequest_PR pipeline #21397 completed with status: 'FAILURE'

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 12, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28060 [ run ] triggered by Bot. Commit: b4047af

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28060 [ run ] completed with state SUCCESS. Commit: b4047af
/LLM/main/L0_MergeRequest_PR pipeline #21433 completed with status: 'FAILURE'

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
@yuxianq yuxianq requested review from a team as code owners December 13, 2025 16:37
@yuxianq yuxianq requested a review from poweiw December 13, 2025 16:37
@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 13, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28118 [ run ] triggered by Bot. Commit: 9902871

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28118 [ run ] completed with state SUCCESS. Commit: 9902871
/LLM/main/L0_MergeRequest_PR pipeline #21476 completed with status: 'FAILURE'

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 14, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28205 [ run ] triggered by Bot. Commit: 130fae9

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28205 [ run ] completed with state SUCCESS. Commit: 130fae9
/LLM/main/L0_MergeRequest_PR pipeline #21558 completed with status: 'FAILURE'

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 15, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28333 [ run ] triggered by Bot. Commit: cc0f53c

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28333 [ run ] completed with state SUCCESS. Commit: cc0f53c
/LLM/main/L0_MergeRequest_PR pipeline #21676 completed with status: 'FAILURE'

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 16, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28495 [ run ] triggered by Bot. Commit: aa0793e

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28693 [ run ] completed with state SUCCESS. Commit: bab30dd
/LLM/main/L0_MergeRequest_PR pipeline #21945 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 18, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28888 [ run ] triggered by Bot. Commit: bab30dd

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28888 [ run ] completed with state SUCCESS. Commit: bab30dd
/LLM/main/L0_MergeRequest_PR pipeline #22124 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 18, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28956 [ run ] triggered by Bot. Commit: 4e867d7

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28956 [ run ] completed with state SUCCESS. Commit: 4e867d7
/LLM/main/L0_MergeRequest_PR pipeline #22183 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 19, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29104 [ run ] triggered by Bot. Commit: 4e867d7

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29104 [ run ] completed with state SUCCESS. Commit: 4e867d7
/LLM/main/L0_MergeRequest_PR pipeline #22317 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 20, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29196 [ run ] triggered by Bot. Commit: 9cc8cd5

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29196 [ run ] completed with state SUCCESS. Commit: 9cc8cd5
/LLM/main/L0_MergeRequest_PR pipeline #22400 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 20, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29245 [ run ] triggered by Bot. Commit: ab18045

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29245 [ run ] completed with state SUCCESS. Commit: ab18045
/LLM/main/L0_MergeRequest_PR pipeline #22449 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 21, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29267 [ run ] triggered by Bot. Commit: ab18045

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29267 [ run ] completed with state SUCCESS. Commit: ab18045
/LLM/main/L0_MergeRequest_PR pipeline #22469 completed with status: 'SUCCESS'

@yuxianq yuxianq merged commit 2f139ee into NVIDIA:main Dec 22, 2025
5 checks passed
codego7250 pushed a commit to codego7250/TensorRT-LLM that referenced this pull request Dec 22, 2025
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
JunyiXu-nv pushed a commit to JunyiXu-nv/TensorRT-LLM that referenced this pull request Dec 30, 2025
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
videodanchik pushed a commit to videodanchik/TensorRT-LLM that referenced this pull request Jan 14, 2026
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
Signed-off-by: Daniil Kulko <kulkodaniil@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants