Skip to content

[https://nvbugs/5666821][chore] unwaive tests.#9958

Merged
yuxianq merged 1 commit intoNVIDIA:mainfrom
yuxianq:unwaive-ds-fp4-b200
Dec 22, 2025
Merged

[https://nvbugs/5666821][chore] unwaive tests.#9958
yuxianq merged 1 commit intoNVIDIA:mainfrom
yuxianq:unwaive-ds-fp4-b200

Conversation

@yuxianq
Copy link
Collaborator

@yuxianq yuxianq commented Dec 12, 2025

Summary by CodeRabbit

  • Tests
    • Re-enabled test validation for model configurations that were previously deferred. These test cases now actively run to ensure compatibility and performance standards.

✏️ Tip: You can customize this high-level summary in your review settings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@yuxianq yuxianq requested a review from EmmaQiaoCh December 12, 2025 17:00
@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 12, 2025

/bot run --disable-fail-fast

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 12, 2025

📝 Walkthrough

Walkthrough

Removed two SKIP markers from the test waives configuration file, un-skipping two DeepSeekV3Lite test cases with different tensor-parallel and moe-backend configurations in the NV-FP4 precision test suite.

Changes

Cohort / File(s) Summary
Test Skip Configuration
tests/integration/test_lists/waives.txt
Removed SKIP markers for two DeepSeekV3Lite NV-FP4 4GPU test configurations (mtp_nextn=0 and mtp_nextn=2), enabling these previously skipped test cases.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning PR description is incomplete; only the template is provided without actual content in the Description and Test Coverage sections. Fill in the Description section explaining why tests are being un-waived, and the Test Coverage section listing the specific tests being un-waived.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title properly follows the repository format with [NVBugs ID][type] summary and clearly indicates the intent to un-skip specific tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28055 [ run ] triggered by Bot. Commit: 575674e

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28055 [ run ] completed with state SUCCESS. Commit: 575674e
/LLM/main/L0_MergeRequest_PR pipeline #21428 completed with status: 'SUCCESS'

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 14, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28201 [ run ] triggered by Bot. Commit: f2f6ded

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28201 [ run ] completed with state SUCCESS. Commit: f2f6ded
/LLM/main/L0_MergeRequest_PR pipeline #21556 completed with status: 'FAILURE'

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 14, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28252 [ run ] triggered by Bot. Commit: f2f6ded

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28252 [ run ] completed with state SUCCESS. Commit: f2f6ded
/LLM/main/L0_MergeRequest_PR pipeline #21605 completed with status: 'FAILURE'

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 15, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28331 [ run ] triggered by Bot. Commit: a2102c1

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28331 [ run ] completed with state SUCCESS. Commit: a2102c1
/LLM/main/L0_MergeRequest_PR pipeline #21673 completed with status: 'FAILURE'

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 16, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28496 [ run ] triggered by Bot. Commit: 7439291

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28496 [ run ] completed with state SUCCESS. Commit: 7439291
/LLM/main/L0_MergeRequest_PR pipeline #21821 completed with status: 'FAILURE'

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 16, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28576 [ run ] triggered by Bot. Commit: 10dae1f

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28576 [ run ] completed with state SUCCESS. Commit: 10dae1f
/LLM/main/L0_MergeRequest_PR pipeline #21891 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 17, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28695 [ run ] triggered by Bot. Commit: 49ff38c

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28695 [ run ] completed with state SUCCESS. Commit: 49ff38c
/LLM/main/L0_MergeRequest_PR pipeline #21948 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 17, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28744 [ run ] triggered by Bot. Commit: 49ff38c

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28744 [ run ] completed with state SUCCESS. Commit: 49ff38c
/LLM/main/L0_MergeRequest_PR pipeline #21991 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 18, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28889 [ run ] triggered by Bot. Commit: 49ff38c

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28889 [ run ] completed with state SUCCESS. Commit: 49ff38c
/LLM/main/L0_MergeRequest_PR pipeline #22125 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 18, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 19, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29103 [ run ] triggered by Bot. Commit: 4e9a39d

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29103 [ run ] completed with state SUCCESS. Commit: 4e9a39d
/LLM/main/L0_MergeRequest_PR pipeline #22316 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 19, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29160 [ run ] triggered by Bot. Commit: 4e9a39d

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29160 [ run ] completed with state SUCCESS. Commit: 4e9a39d
/LLM/main/L0_MergeRequest_PR pipeline #22365 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 20, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29197 [ run ] triggered by Bot. Commit: 544fd2e

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29197 [ run ] completed with state SUCCESS. Commit: 544fd2e
/LLM/main/L0_MergeRequest_PR pipeline #22401 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 20, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29246 [ run ] triggered by Bot. Commit: 05d8f5b

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29246 [ run ] completed with state SUCCESS. Commit: 05d8f5b
/LLM/main/L0_MergeRequest_PR pipeline #22448 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 21, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29268 [ run ] triggered by Bot. Commit: 05d8f5b

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29268 [ run ] completed with state SUCCESS. Commit: 05d8f5b
/LLM/main/L0_MergeRequest_PR pipeline #22470 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 21, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29304 [ run ] triggered by Bot. Commit: 05d8f5b

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29304 [ run ] completed with state SUCCESS. Commit: 05d8f5b
/LLM/main/L0_MergeRequest_PR pipeline #22501 completed with status: 'SUCCESS'

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
@yuxianq yuxianq force-pushed the unwaive-ds-fp4-b200 branch from 05d8f5b to 276f76e Compare December 22, 2025 02:47
@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 22, 2025

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29351 [ reuse-pipeline ] triggered by Bot. Commit: 276f76e

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29351 [ reuse-pipeline ] completed with state SUCCESS. Commit: 276f76e
Reusing PR_Github #29304 for commit 276f76e

@yuxianq yuxianq merged commit 237fd0e into NVIDIA:main Dec 22, 2025
5 checks passed
codego7250 pushed a commit to codego7250/TensorRT-LLM that referenced this pull request Dec 22, 2025
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
JunyiXu-nv pushed a commit to JunyiXu-nv/TensorRT-LLM that referenced this pull request Dec 30, 2025
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
videodanchik pushed a commit to videodanchik/TensorRT-LLM that referenced this pull request Jan 14, 2026
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
Signed-off-by: Daniil Kulko <kulkodaniil@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants