Skip to content

TREX(trt-engine-explorer): fix matadata typo (breaks report_card) and compatibility between dtale and dash #4578

@nimdrak

Description

@nimdrak

I’m opening this issue in case it helps someone. If it’s useful, I’m happy to put together a PR.

Summary

In detail

1) Typo: matadata

There are a few occurrences of matadata in trex/report_card.py.
This leads to a runtime error when calling report_card_draw_plan_graph_extended:

Example error stack (abbreviated):

.../trex/graphing.py:832 in to_dot
g = DotGraph(*args, **kwargs)
TypeError: DotGraph.__init__() got an unexpected keyword argument 'display_matadata'

Proposed fix
Rename all matadata to metadata across TREX code where used.

2) dtaledash compatibility

dtale imports dash.development.component_loader, which was removed in dash 3.0+.
With dash ≥ 3.0, this raises:

AttributeError: module 'dash.development' has no attribute 'component_loader'

Proposed fix
We can fix it in two ways
(1) Update the dtale version (fix man-group/dtale#904)

# requirements-notebook.txt
dtale==3.18.2 # okay only if higher than 3.17.0

(2) Or pin dash to the last 2.x release in the notebook environment:

# requirements-notebook.txt
dash==2.18.2

This keeps dtale operational without changes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions