Conversation
ArangoGutierrez
left a comment
There was a problem hiding this comment.
Hey Kevin, thanks for adding this. A couple things to fix before this is ready.
recipes/registry.yaml
Outdated
| healthCheck: | ||
| assertFile: checks/kueue/health-check.yaml | ||
| helm: | ||
| defaultRepository: oci://registry.k8s.io/kueue |
There was a problem hiding this comment.
This path is wrong. The bundler constructs {Repository}/{ChartName}, so this resolves to oci://registry.k8s.io/kueue/kueue but the chart actually lives at oci://registry.k8s.io/kueue/charts/kueue.
Should be:
defaultRepository: oci://registry.k8s.io/kueue/chartsYou can verify with:
helm show chart oci://registry.k8s.io/kueue/charts/kueue --version v0.17.0
|
|
||
| controllerManager: | ||
| tolerations: | ||
| - operator: Exists |
There was a problem hiding this comment.
Worth checking what the upstream chart defaults are for resource requests and security context. If they look good, a short comment here saying so would help (see kai-scheduler/values.yaml for an example of documenting why values are minimal). If not, we should pin them explicitly.
|
I'm having a hard time figuring out how to test this on a kind cluster. I was thinking that I could have a bundle and verify simple kind cluster for Kueue but can't figure out how to do that. |
Signed-off-by: Kevin Hannon <kehannon@redhat.com>
9a20673 to
3f702e0
Compare
In response to this comment, I have created #508 , with it, is easier for contributors to fully test the component in a controlled environment, even if the contributor doesn't have access to a GPU by using the NVML-Mock project. Hope this helps @kannon92 |
Cross-Review Summary for PR #490Reviewers: Codex, CodeRabbit + Integration Analysis Confirmed IssuesNone. The PR is correct as written. Positive Observations
Cross-review by Claude Code + Codex + CodeRabbit |
Summary
Add kueue recipe.
Motivation / Context
Fixes: #486
Related:
Type of Change
Component(s) Affected
cmd/aicr,pkg/cli)cmd/aicrd,pkg/api,pkg/server)pkg/recipe)pkg/bundler,pkg/component/*)pkg/collector,pkg/snapshotter)pkg/validator)pkg/errors,pkg/k8s)docs/,examples/)Implementation Notes
Testing
# Commands run (prefer `make qualify` for non-trivial changes) make qualifyRisk Assessment
Rollout notes:
Checklist
make testwith-race)make lint)git commit -S) — GPG signing info