chore: cleaning up examples of is_some() + unwrap()#362
Merged
chet merged 1 commit intoNVIDIA:mainfrom Feb 23, 2026
Merged
Conversation
I noticed a few of these last week when I was doing some other work, and figured I'd sweep through and find ~most remaining examples of this. Insetad of `x.is_some()` followed by `let y = x.unwrap()`, just use `if let Some(..)`, and a few other pattern adjustments. All existing tests contiuning to pass. I checked to see if I needed to add any additional test coverage here but it all appears covered. Signed-off-by: Chet Nichols III <chetn@nvidia.com>
wminckler
approved these changes
Feb 23, 2026
kensimon
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed a few of these last week when I was doing some other work, and figured I'd sweep through and find ~most remaining examples of this. Insetad of
x.is_some()followed bylet y = x.unwrap(), just useif let Some(..), and a few other pattern adjustments (including some similar.is_none()use-cases).All existing tests contiuning to pass. I checked to see if I needed to add any additional test coverage here but it all appears covered.
Signed-off-by: Chet Nichols III chetn@nvidia.com
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes