install cmake bits to DATADIR instead of LIBDIR

[anbe42]

thrust and cub are architecture-independent header-only libraries, therefore their *.cmake bits should be placed under /usr/share/cmake/ instead of /usr/lib*/cmake/ (which is the architecture dependent /usr/lib/<triplet>/cmake/ on Debian and derivatives).
Please switch from CMAKE_INSTALL_LIBDIR to CMAKE_INSTALL_DATADIR. This also avoids embedding an architecture-dependent path in the generated thrust-header-search.cmake and cub-header-search.cmake

[anbe42]

BTW, the repositories contain thrust-header-search.cmake and cub-header-search.cmake. These should probably be removed as they are to be generated from the corresponding *-header-search.cmake.in files instead.

This results in *-header-search.cmake being installed twice: first the stale copy from the source tree, then overwritten with the generated file from the build tree:

...
-- Installing: /tmp/cubtest2/usr/local/lib/cmake/cub/cub-header-search.cmake
-- Installing: /tmp/cubtest2/usr/local/lib/cmake/cub/cub-header-search.cmake.in
-- Installing: /tmp/cubtest2/usr/local/lib/cmake/cub/cub-header-search.cmake

[jrhemstad]

I'll need to defer to @allisonvacanti or @robertmaynard on this one.

[robertmaynard]

BTW, the repositories contain thrust-header-search.cmake and cub-header-search.cmake. These should probably be removed as they are to be generated from the corresponding *-header-search.cmake.in files instead.

This results in *-header-search.cmake being installed twice: first the stale copy from the source tree, then overwritten with the generated file from the build tree:

...
-- Installing: /tmp/cubtest2/usr/local/lib/cmake/cub/cub-header-search.cmake
-- Installing: /tmp/cubtest2/usr/local/lib/cmake/cub/cub-header-search.cmake.in
-- Installing: /tmp/cubtest2/usr/local/lib/cmake/cub/cub-header-search.cmake

That double install has already been fixed on the main branch of thrust and cub ( NVIDIA/thrust#1825 )

[robertmaynard]

thrust and cub are architecture-independent header-only libraries, therefore their *.cmake bits should be placed under /usr/share/cmake/ instead of /usr/lib*/cmake/ (which is the architecture dependent /usr/lib/<triplet>/cmake/ on Debian and derivatives). Please switch from CMAKE_INSTALL_LIBDIR to CMAKE_INSTALL_DATADIR. This also avoids embedding an architecture-dependent path in the generated thrust-header-search.cmake and cub-header-search.cmake

Switching to CMAKE_INSTALL_DATADIR will be a breaking change. Projects use variables likeTHRUST_ROOT_DIR to specify the location and that would fail, or people package Thrust as a sub-component and now the layout will change.