This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Deprecate debug synchronous#527
Merged
gevtushenko merged 3 commits intoNVIDIA:mainfrom Jul 19, 2022
Merged
Conversation
gevtushenko
added
the
P0: must have
gevtushenko
force-pushed
the
fix-main/github/deprecate_debug_synchronous
branch
2 times, most recently
from
be78b65 to
7e66c4a
Compare
Closed
alliepiper
approved these changes
Jul 18, 2022
Collaborator
alliepiper
left a comment
alliepiper
left a comment
There was a problem hiding this comment.
Reviewed the new features and some of the usage sites. Some minor suggestions inline.
gevtushenko
force-pushed
the
fix-main/github/deprecate_debug_synchronous
branch
from
7e66c4a to
e7a3538
Compare
miscco
approved these changes
Jul 19, 2022
Collaborator
miscco
left a comment
miscco
left a comment
There was a problem hiding this comment.
There is a potential issue with unused arguments warnings, but I am not really sure whether we care
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issue