This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Support __{u,}int128_t in radix sort#607
Merged
Merged
Conversation
gevtushenko
added
testing: gpuCI passed
miscco
approved these changes
Jan 3, 2023
miscco
left a comment
miscco
left a comment
Collaborator
There was a problem hiding this comment.
That is awesome, thanks a lot. I assume that int128 implicitly requires uint128 which has the same switch?
elstehle
approved these changes
Jan 3, 2023
elstehle
left a comment
elstehle
left a comment
Collaborator
There was a problem hiding this comment.
Great work, looks solid!
canonizer
suggested changes
Jan 5, 2023
gevtushenko
added a commit
to gevtushenko/thrust
that referenced
this pull request
Jan 6, 2023
canonizer
approved these changes
Jan 6, 2023
canonizer
left a comment
canonizer
left a comment
Contributor
There was a problem hiding this comment.
Approved, provided that the comments are addressed.
gevtushenko
force-pushed
the
enh-main/github/sort_128
branch
from
56cad37 to
475f96f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supports
__int128_tand__uint128_tin block/device radix sort as well as block radix rank. It's partially answering the question on 128 bit types support. Performance wise,__int128_tutilize BW similarly to 64 bit types.