Repository navigation
Conversation
The first-kernel walkthrough told readers to run `cargo oxide doctor` straight after installing cargo-oxide, before `cargo oxide new`. Outside the repository and outside a project, doctor has nothing to inspect and stops with "Could not find cuda-oxide workspace or a standalone Cargo.toml", so the second command of the guide fails for every new user. Move the check after `cd my_first_kernel`, which is also the order `cargo oxide new` prints. Doctor reads the project's toolchain pin and dependencies, which is why it needs the project. Signed-off-by: Vyncint Ng <115854244+vyncint@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1714.
hello-gpu.mdrancargo oxide doctorstraight after installing cargo-oxide, beforecargo oxide new. Outside the repository and outside a project, doctor stops withCould not find cuda-oxide workspace or a standalone Cargo.toml, so the guide's second command failed for anyone following it.This moves the step to after
cd my_first_kernel, which is also the ordercargo oxide newprints:The explanation moves with it. It gains one sentence saying that doctor reads the project's toolchain pin and dependencies, which is why it runs from the project directory.
Checked:
cargo-oxidebuilt frommain(538f4839), doctor exits 1 with that error in an empty directory. In the new order (cargo oxide new my_first_kernel,cd,cargo oxide doctor), it exits 0 with 13 checks passing.cuda-oxide/v0.3.0tag.just bookbuilds with warnings as errors.