Add more tests to cover containerd/driver container k8s deployments #1139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supertetelman
force-pushed
the
more-tests
branch
from
9dfb377 to
d30b231
Compare
ajdecon
reviewed
Mar 29, 2022
| timeout 180 bash -x ./workloads/jenkins/scripts/test-dashboard.sh | ||
| ''' | ||
|
|
||
| echo "Start new virtual environment pre-Slurm checks" |
Contributor
There was a problem hiding this comment.
Do we need to explicitly tear down the VMs before we do this?
Contributor
Author
There was a problem hiding this comment.
Tearing them down is part of this script.
supertetelman
force-pushed
the
more-tests
branch
from
3c4471d to
efcf7aa
Compare
supertetelman
force-pushed
the
more-tests
branch
from
efcf7aa to
dbf4c87
Compare
ajdecon
approved these changes
Mar 30, 2022
Contributor
ajdecon
left a comment
ajdecon
left a comment
There was a problem hiding this comment.
LGTM. Confirmed that tests passed in nightly builds.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have the following configurations to test.
This change covers these all in the nightlies and it will probably take around 4 hours end to end.
I tried to mix-and-match the actual tests being run across them so that we have some confidence without filling out a dense test matrics. Kubeflow is tested once on GPU Operator and once on device plugin.
I skipped the local-registry tests on containerd installs, but kept it in for docker installs. This may or may not work given the recent changes.
I made sure that the monitoring stack is tested with at least one configuration of device plugin, docker, containerd, and driver-container configurations.