Update NVIDIA signing key #1166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajdecon
force-pushed
the
update-nv-signing-key
branch
from
c71b30d to
53caa74
Compare
| mode: "0644" | ||
|
|
||
| - name: Ubuntu | add key | ||
| - name: Ubuntu | ensure old key is absent |
Contributor
There was a problem hiding this comment.
Do we want to eventually remove this or does it stay here forever?
Contributor
Author
There was a problem hiding this comment.
Unclear. In principle I think this could be removed once we were confident all existing installs were updated. But it's hard to know when that is. 🤷🏻♂️
If I were being ultra-conservative, I'd say this could be removed when the last released drivers signed by the old key are EOL (r470, July 2024). We might be able to come up with a faster schedule than that though.
However, I don't think this task is doing any harm (apart from code clutter). So I don't think there would be any rush to remove this.
supertetelman
previously approved these changes
Apr 29, 2022
Contributor
supertetelman
left a comment
supertetelman
left a comment
There was a problem hiding this comment.
LGTM, let's see it pass testing.
See https://developer.nvidia.com/blog/updating-the-cuda-linux-gpg-repository-key/ for details on the key changes. This commit: - Removes the nvidia-ml repo, which is deprecated and will not be updated - Updates the nvidia_cuda and nvidia_dcgm roles to use the new key and install workflow - Updates roles/requirements.txt to point to an updated version of nvidia.nvidia_driver
ajdecon
force-pushed
the
update-nv-signing-key
branch
from
7220f33 to
8a8b560
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Repository signing keys have changed, so we need to update the automation to match. https://developer.nvidia.com/blog/updating-the-cuda-linux-gpg-repository-key/
roles/requirements.txtfor updated version ofnvidia.nvidia_driverrole (depends on Update to new NVIDIA signing key ansible-role-nvidia-driver#59)Test plan
Passing CI tests.