EasyBuild: Enable both shells on all distros #993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our current EasyBuild role enables the bash profile on Debian-based systems, and the csh profile on RedHat-based systems, but not vice-versa. There's no clear reason for this limitation, so let's remove it.
Contributor
Author
|
@issamsaid : This behavior was included in your commit 54b2636, can you clarify if this was intended and why? |
michael-balint
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current EasyBuild role enables the bash profile on Debian-based systems, and the csh profile on RedHat-based systems, but not vice-versa. There's no clear reason for this limitation, so let's remove it.
Addresses #987 .