fix: add standardized exit codes on improper exit (issue #1221)#1651
Open
aniu26 wants to merge 1 commit intoNVIDIA:mainfrom
Open
fix: add standardized exit codes on improper exit (issue #1221)#1651aniu26 wants to merge 1 commit intoNVIDIA:mainfrom
aniu26 wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
aniu26
commented
Mar 26, 2026
aniu26
commented
- Add GarakExitCodes IntEnum to exception.py with 11 exit codes: INTERRUPTED=-1, PROBE_EXCEPTION=-2, GENERATOR_EXCEPTION=-3, DETECTOR_EXCEPTION=-4, BUFF_EXCEPTION=-5, EVALUATOR_EXCEPTION=-6, HARNESS_EXCEPTION=-7, LANGPROVIDER_EXCEPTION=-8, REPORTING_EXCEPTION=-9, RESOURCE_EXHAUSTED=-10, UNSPECIFIED_EXCEPTION=-127
- Fix KeyboardInterrupt handler: was exiting 0, now exits -1
- Fix ValueError/GarakException handler: was exiting 0, now exits -127
- Fix interactive mode handler: was exit(1), now uses GarakExitCodes
- Add GarakExitCodes IntEnum to exception.py with 11 exit codes: INTERRUPTED=-1, PROBE_EXCEPTION=-2, GENERATOR_EXCEPTION=-3, DETECTOR_EXCEPTION=-4, BUFF_EXCEPTION=-5, EVALUATOR_EXCEPTION=-6, HARNESS_EXCEPTION=-7, LANGPROVIDER_EXCEPTION=-8, REPORTING_EXCEPTION=-9, RESOURCE_EXHAUSTED=-10, UNSPECIFIED_EXCEPTION=-127 - Fix KeyboardInterrupt handler: was exiting 0, now exits -1 - Fix ValueError/GarakException handler: was exiting 0, now exits -127 - Fix interactive mode handler: was exit(1), now uses GarakExitCodes
Contributor
|
DCO Assistant Lite bot All contributors have signed the DCO ✍️ ✅ |
Author
|
I have read the DCO Document and I hereby sign the DCO |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
jmartin-tech
requested changes
Mar 31, 2026
Collaborator
jmartin-tech
left a comment
jmartin-tech
left a comment
There was a problem hiding this comment.
Please review test failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.