Remove the CC_CAPABLE_DEVICE_IDS variable#2269
Merged
cdesiniotis merged 1 commit intoNVIDIA:mainfrom Apr 8, 2026
Merged
Conversation
Contributor
|
Looks good. Just wondering why https://github.com/NVIDIA/gpu-operator/blob/main/assets/state-cc-manager/0500_daemonset.yaml never had the env passed into it. |
The use of this variable has been obsoleted in k8s-cc-manager, hence removing the variable from values.yaml Signed-off-by: Manuel Huber <manuelh@nvidia.com>
manuelh-dev
force-pushed
the
mahuber/rem-cc-device-id
branch
from
5a330cf to
a704127
Compare
manuelh-dev
requested review from
cdesiniotis,
karthikvetrivel,
rahulait,
rajathagasthya,
shivamerla and
tariq1890
as code owners
rajatchopra
approved these changes
Apr 8, 2026
Contributor
Author
|
@cdesiniotis @tariq1890 - could you please take a look? |
cdesiniotis
approved these changes
Apr 8, 2026
Contributor
|
/ok to test a704127 |
Contributor
|
/cherry-pick release-26.3 |
Contributor
This env used to be hardcoded in the daemonset template, but was removed in eea29f1. Looks like we forgot to remove it from the helm values as well. Thanks @manuelh-dev for the contribution! |
Contributor
|
🤖 Backport PR created for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use of this variable has been obsoleted in k8s-cc-manager, hence removing the variable from values.yaml