Skip to content
This repository was archived by the owner on Mar 21, 2024. It is now read-only.

Add find_package and add_subdirectory CMake support.#242

Merged
wmaxey merged 1 commit into
NVIDIA:mainfrom
alliepiper:cmake_package
Feb 12, 2022
Merged

Add find_package and add_subdirectory CMake support.#242
wmaxey merged 1 commit into
NVIDIA:mainfrom
alliepiper:cmake_package

Conversation

@alliepiper
Copy link
Copy Markdown
Collaborator

@alliepiper alliepiper commented Jan 18, 2022

To validate installation + packages, run the new tests:

mkdir build
cd build
cmake -Dlibcudacxx_ENABLE_CMAKE_TESTS=ON ..
ctest --output-on-failure

Tests are failing until #241 is merged.

@wmaxey wmaxey added the enhancement New feature or request. label Jan 18, 2022
@wmaxey wmaxey added this to the 1.8.0 milestone Jan 18, 2022
robertmaynard
robertmaynard reviewed Jan 19, 2022
View reviewed changes
Comment thread cmake/libcudacxxInstallRules.cmake Outdated
Comment thread cmake/test/test_export/CMakeLists.txt Outdated
@alliepiper
Copy link
Copy Markdown
Collaborator Author

alliepiper commented Jan 21, 2022

Last push fixed a bug in the versions checks (cc: @robertmaynard)

@wmaxey
Copy link
Copy Markdown
Member

wmaxey commented Jan 21, 2022

VDVS: http://scdvs.nvidia.com/Build_Results?virtualId=1000081020&which_page=current_build
VDVS: http://ausdvs.nvidia.com/Build_Results?virtualId=1001080494&which_page=current_build

@wmaxey wmaxey added testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). testing: internal ci passed Passed internal NVIDIA CI (DVS). and removed testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). labels Jan 21, 2022
robertmaynard
robertmaynard suggested changes Jan 27, 2022
View reviewed changes
Comment thread lib/cmake/libcudacxx/libcudacxx-config.cmake
robertmaynard
robertmaynard suggested changes Jan 27, 2022
View reviewed changes
Comment thread CMakeLists.txt
@alliepiper
Add find_package and add_subdirectory CMake support.
d6246ca 
To validate installation + packages, run the new tests:

```
mkdir build
cd build
cmake -Dlibcudacxx_ENABLE_CMAKE_TESTS=ON ..
ctest --output-on-failure
```
@alliepiper
Copy link
Copy Markdown
Collaborator Author

alliepiper commented Feb 7, 2022

@wmaxey This should be ready to go -- I've been using the package in thrust successfully in NVIDIA/thrust#1605 👍

@alliepiper alliepiper linked an issue Feb 7, 2022 that may be closed by this pull request
Provide proper CMake module support #209
Closed
@alliepiper
Copy link
Copy Markdown
Collaborator Author

alliepiper commented Feb 7, 2022

BTW @wmaxey -- you'll need to ping the builds folks to make sure that these three files get packaged into CTK. See NVBug 3273504 where we did this for Thrust/CUB.

$SRC_DIR/lib/cmake/libcudacxx/libcudacxx-config.cmake         -> $CTK_ROOT/lib/cmake/libcudacxx/libcudacxx-config.cmake
$SRC_DIR/lib/cmake/libcudacxx/libcudacxx-config-version.cmake -> $CTK_ROOT/lib/cmake/libcudacxx/libcudacxx-config-version.cmake
$SRC_DIR/lib/cmake/libcudacxx/libcudacxx-header-search.cmake  -> $CTK_ROOT/lib/cmake/libcudacxx/libcudacxx-header-search.cmake

@wmaxey wmaxey merged commit 194dd51 into NVIDIA:main Feb 12, 2022
@alliepiper alliepiper deleted the cmake_package branch February 19, 2022 22:09
@wmaxey wmaxey mentioned this pull request May 9, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@griwes griwes Awaiting requested review from griwes

@wmaxey wmaxey Awaiting requested review from wmaxey

1 more reviewer

@robertmaynard robertmaynard robertmaynard approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request. testing: internal ci passed Passed internal NVIDIA CI (DVS).

Projects

None yet

Milestone

1.8.0

Development

Successfully merging this pull request may close these issues.

Provide proper CMake module support

3 participants

@alliepiper @wmaxey @robertmaynard