Drop test-wheels-deps-wheels job and orphaned build scripts#872
Draft
leofang wants to merge 3 commits into
Draft
Drop test-wheels-deps-wheels job and orphaned build scripts#872leofang wants to merge 3 commits into
leofang wants to merge 3 commits into
Conversation
Remove the `test-wheels-deps-wheels` old-CI job from `ci.yaml` and delete three scripts that are no longer referenced by any workflow: - ci/build_wheel.sh — replaced by cibuildwheel in build-wheel.yml - ci/build_wheel.ps1 — Windows equivalent, same story - ci/test_wheel_deps_wheels.sh — only caller was the removed job The new VM-based CI (PR NVIDIA#604) already covers wheel-level testing via test-wheel-linux.yml and test-wheel-windows.yml, making the old container-based `test-wheels-deps-wheels` job redundant. Note: `test-wheels-deps-wheels` was not in the `checks` job's `needs` list, so this removal does not affect the merge gate. Closes NVIDIA#671 (partially)
BUILD_MATRIX was computed by the `compute-matrix` job but never referenced by any downstream job. Remove it from the outputs, the shell script, and the corresponding `build-matrix` section in ci/matrix.yml.
leofang
force-pushed
the
leof/drop-test-wheels-deps-wheels
branch
from
c5e5185 to
eb39e39
Compare
Move the old container-based CI matrix entries into ci/test-matrix.yml under linux.pull-request-legacy, and the simulator matrix under a top-level simulator key. Update compute-matrix to read from the new locations. Changes vs the old matrix: - Hard-wire LINUX_VER to ubuntu22.04 directly in the old CI reusable workflows and drop the field from the matrix entirely - Drop all CUDA 12.9.1 and 13.0.0 entries (already covered by the new CI) - Retain 12.0.1 and 12.2.2 entries with their accompanying NUMBA_VERSION / CUDA_CORE_VERSION pins ci/matrix.yml is now fully redundant and deleted.
leofang
force-pushed
the
leof/drop-test-wheels-deps-wheels
branch
from
eb39e39 to
060aee1
Compare
Member
Author
|
/ok to test 060aee1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clean up old CI artefacts as part of the transition to the new VM-based CI (#671).
Commit 1 — Drop
test-wheels-deps-wheelsjob and orphaned build scriptsRemove the old-CI
test-wheels-deps-wheelsjob fromci.yamland delete three scripts that are no longer referenced by any workflow:ci/build_wheel.sh— replaced bycibuildwheelinbuild-wheel.yml(Set up a new VM-based CI infrastructure #604)ci/build_wheel.ps1— Windows equivalent, same storyci/test_wheel_deps_wheels.sh— only caller was the removed jobtest-wheels-deps-wheelswas not in thechecksjob'sneedslist, so this removal does not affect the merge gate.Commit 2 — Remove dead
BUILD_MATRIXoutputBUILD_MATRIXwas computed by thecompute-matrixjob but never consumed by any downstream job. Remove it from the outputs, the shell script, and the correspondingbuild-matrixsection inci/matrix.yml.Commit 3 — Consolidate
ci/matrix.ymlintoci/test-matrix.ymlMove the old container-based CI matrix entries into
ci/test-matrix.yml:test-matrix→linux.pull-request-legacy(6 entries: CUDA 12.0.1 and 12.2.2)simulator-matrix→ top-levelsimulatorkeyChanges vs the old matrix:
LINUX_VERtoubuntu22.04directly in the three old CI reusable workflows (conda-python-tests.yaml,simulator-test.yaml,wheels-test.yaml) and drop the field from the matrix entirelyNUMBA_VERSION/CUDA_CORE_VERSIONpins for oldest-dep compat testingci/matrix.ymlis now fully redundant and deleted.Partially addresses #671.
-- Leo's bot