Add support for building ubuntu22.04 on amd64#1004
Merged
elezar merged 2 commits intoNVIDIA:mainfrom Apr 17, 2025
dschervov:main
Merged
Add support for building ubuntu22.04 on amd64#1004elezar merged 2 commits intoNVIDIA:mainfrom dschervov:main
elezar merged 2 commits intoNVIDIA:mainfrom
dschervov:main
Conversation
Signed-off-by: Dmitrii Chervov <dschervov1@yandex.ru>
Contributor
Author
|
@elezar Can you please check my PR? |
elezar
reviewed
Apr 2, 2025
Member
elezar
left a comment
There was a problem hiding this comment.
@dschervov please also add an arm64 target for ubuntu22.04 for consistency.
Signed-off-by: Dmitrii Chervov <dschervov1@yandex.ru>
Contributor
Author
Thank you @elezar for your quick response! I am sorry for not responding right away : - ( At that time, I didn't have an ARM64... So I couldn't just send to you something that I am not sure if it would work. However!!! I have friends who gave me an ARM64! So I implemented your suggestion and tested it. It works perfectly! |
Member
|
Just a note. The ubuntu18.04 builds should work on newer ubuntu versions too. |
Contributor
Author
I appreciate you sharing the knowledge! |
elezar
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual build for nvidia-contaier-toolkit is necessary! It can help open source community with debug and adding new features to this magnificent utility!
Manual build correct working was tested by me on ubuntu22.04 (run docker with gpus all on different models).