This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Fix bug in final eval_if branch in iterator_category_to_traversal.h metafunctions#1683
Merged
ericniebler merged 1 commit intoMay 10, 2022
Conversation
… metafunctions Whether this is actually a bug or not depends on intent: if the intent is to force a hard error if we reach the final `eval_if` branch, then the code is correct as-is. If, however, the intent is for the metafunctions to evaluate to `void` as I suspect, then this is a bug.
ericniebler
added
P1: should have
Collaborator
Author
|
run tests |
alliepiper
approved these changes
May 10, 2022
Collaborator
alliepiper
left a comment
alliepiper
left a comment
There was a problem hiding this comment.
LGTM, agreed that the intent was likely to alias void rather than error out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whether this is actually a bug or not depends on intent: if the intent is to force a hard error if we reach the final
eval_ifbranch, then the code is correct as-is. If, however, the intent is for the metafunctions to evaluate tovoidas I suspect, then this is a bug.