This repository was archived by the owner on Mar 21, 2024. It is now read-only.
copy_if doesn't require copy assignment operator for OutputIterator#1756
Merged
alliepiper merged 3 commits intoJul 28, 2022
Merged
Conversation
Collaborator
|
Can one of the admins verify this patch? Admins can comment |
alliepiper
suggested changes
Jul 27, 2022
Collaborator
alliepiper
left a comment
alliepiper
left a comment
There was a problem hiding this comment.
The change looks reasonable, but go ahead and remove the return statement following the THRUST_CDP_DISPATCH macro -- compilers will flag that as unreachable code and emit warnings.
alliepiper
added
type: bug: functional
alliepiper
approved these changes
Jul 27, 2022
Collaborator
|
run tests |
alliepiper
added
the
testing: internal ci in progress
miscco
approved these changes
Jul 28, 2022
Collaborator
miscco
left a comment
miscco
left a comment
There was a problem hiding this comment.
Thanks a lot for that contribution! 🎉
Collaborator
|
run tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For OutputIterators who don't have copy assignment operator, the assignment into result was giving a compiler error. This change avoids using the copy assignment operator.