Replace ClientContext/TabletLocator/MetadataServicer with AccumuloTableInfoFetcher facade#3449
Open
SethSmucker wants to merge 5 commits intointegrationfrom
Open
Replace ClientContext/TabletLocator/MetadataServicer with AccumuloTableInfoFetcher facade#3449SethSmucker wants to merge 5 commits intointegrationfrom
SethSmucker wants to merge 5 commits intointegrationfrom
Conversation
…Is (#2443) Create AccumuloTableInfoFetcher in core/connection-pool that centralizes Accumulo table metadata operations behind public APIs, replacing direct usage of ClientContext, ThriftClientTypes, TabletLocator, and MetadataServicer. Migrated callers: - BulkIngestMapFileLoader: replace Thrift RPC with getActiveCompactions() - TableSplitsCache: replace MetadataServicer with locate() API - BulkInputFormat: replace TabletLocator/ClientContext online path with locate() API; offline path deferred (uses KeyExtent, separate task) Also removes TabletLocator from import-control-accumulo.xml allowlist.
SethSmucker
force-pushed
the
task/clientcontext-facade-migration
branch
from
e9a4617 to
5f29ebf
Compare
jschmidt10
reviewed
Mar 22, 2026
.../connection-pool/src/main/java/datawave/core/common/connection/AccumuloTableInfoFetcher.java
Outdated
Show resolved
Hide resolved
jschmidt10
reviewed
Mar 22, 2026
| * Get the count of running major compactions across all tablet servers using the public {@code getActiveCompactions()} API. | ||
| * <p> | ||
| * Note: This counts only running compactions (not queued), which differs slightly from the original Thrift-based implementation that also counted queued | ||
| * compactions. This is acceptable because the MAJC_THRESHOLD default is 3000 (a high safety margin) and this is polled on each bulk load cycle. |
Collaborator
There was a problem hiding this comment.
jschmidt10
reviewed
Mar 22, 2026
warehouse/core/src/main/java/datawave/mr/bulk/BulkInputFormat.java
Outdated
Show resolved
Hide resolved
jschmidt10
reviewed
Mar 22, 2026
jschmidt10
reviewed
Mar 22, 2026
- Remove implementation details from AccumuloTableInfoFetcher javadocs - Throw TableNotFoundException instead of TableDeletedException in BulkInputFormat - Add datawave-core-connection-pool to root pom dependencyManagement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AccumuloTableInfoFetcherfacade in core/connection-pool centralizing Accumulo metadata operations behind public APIsBulkIngestMapFileLoader.getMajorCompactionCount()withgetActiveCompactions()APIMetadataServicerinTableSplitsCachewithlocate()APITabletLocator/ClientContextinBulkInputFormatonline path withlocate()APITabletLocatorfrom import-control-accumulo.xml allowlistPart of #2443