Invalid XML kills livesync

[bradmartin]

Using livesync, if you bork the XML and save changes. The app crashes, which is fine, but then after correcting the invalid XML you have to do a new build for Android to get the app to livesync again. Big time killer. It's come up on the slack channel a couple of time and confuses people who don't know how to get around it.

[enchev]

Hey @bradmartin,

Maybe we should stop deploying broken XML at all? Right now you will get only warning from the CLI if the XML is invalid however we can change that to real error which will stop the current task (livesync, run, etc.).

Hey @atanasovg @dtopuzov @hdeshev @hshristov @PanayotCankov @rosen-vladimirov what do you think?

[bradmartin]

Anything to prevent the need to rebuild and start livesync over I'm all
for. Sometimes I even forget to do that and get frustrated and I've been
around for awhile so I just don't want newer NativeScript devs to get
frustrated and give up 😄 I trust you guys to implement a good
solution. Most of the time for me my IDE might throw in an extra double
quote when im making quick attribute property changes. I know I can change
the IDE auto completion settings but that's besides the issue. So again
thanks for getting a discussion going so this can be resolved. Its my only
livesync complaint to be honest.

On Thu, May 26, 2016, 8:32 AM Vladimir Enchev notifications@github.com
wrote:

Hey @bradmartin https://github.com/bradmartin,

Maybe we should stop deploying broken XML at all? Right now you will get
only warning from the CLI if the XML is invalid however we can change that
to real error which will stop the current task (livesync, run, etc.).

Hey @atanasovg https://github.com/atanasovg @dtopuzov
https://github.com/dtopuzov @hdeshev https://github.com/hdeshev
@hshristov https://github.com/hshristov @PanayotCankov
https://github.com/PanayotCankov @rosen-vladimirov
https://github.com/rosen-vladimirov what do you think?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1777 (comment)

[rosen-vladimirov]

Hi guys,
I believe we should not stop the livesync when there's invalid XML, but we should not livesync the file as well. My idea is to validate the file and tell the user: "Hey, this file's incorrect, fix it, save it and we'll do the job for you". So the user will not restart the operation, we'll check the file and if we consider it as valid, we'll send it to device.

[enchev]

We have similar issue for TypeScript compilation. In both cases (XML is not well formed and TypeScript cannot be compiled) in my opinion we should stop the transfer (not the watch itself). When you fix all errors your files will be transferred automatically again.

[hdeshev]

I also think we should alert the user by changing the app behavior when we prevent a sync due to an error. Here's how RN does it for app crashes:

We should use that for compile errors, xml validation failures, etc.

[enchev]

Hey,

I've played a bit with various approaches and here is what I've found:

Approach A (Stop livesync transfer in case of XML error)

• (pros): will notify the developer in the livesync console about errors in any XML file in the application
• (cons): the developer may not notice the error in the console since the application will not react in any way

Approach B (Continue livesync transfer in case of XML error)

• (pros): will notify the developer in both livesync console and the app (via alert, modal page, etc.)
• (cons): the developer will be alerted in the app only about the current page errors. If you have invalid XML in other pages you will not know until you try to open the page at runtime.

I suggest to move on with my current pull request and research the B approach and eventually implement it in the near future.

Thanks

[UPDATE] Ok. I've managed to implement the B approach in the modules. Here is how it works: