fix(API): isValidNativeScriptProject returns incorrect result#3580
Merged
rosen-vladimirov merged 1 commit intomasterfrom May 14, 2018
Merged
fix(API): isValidNativeScriptProject returns incorrect result#3580rosen-vladimirov merged 1 commit intomasterfrom
rosen-vladimirov merged 1 commit intomasterfrom
Conversation
In case CLI is used as a library and `isValidNativeScriptProject` is called multiple times, it does not return correct results after the first time. The problem is that it uses the singleton object - projectData. Change the implementation to use projectDataService, this way the method will always return correc results.
Fatme
approved these changes
May 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case CLI is used as a library and
isValidNativeScriptProjectis called multiple times, it does not return correct results after the first time.The problem is that it uses the singleton object - projectData. Change the implementation to use projectDataService, this way the method will always return correc results.
PR Checklist
What is the current behavior?
In case CLI is used as a library and
isValidNativeScriptProjectis called multiple times, it does not return correct results after the first time.What is the new behavior?
In case CLI is used as a library and
isValidNativeScriptProjectis called multiple times, it returns correct results.