Skip to content

feat: handle empty platforms folder #5463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rigor789 merged 4 commits into from
Jan 26, 2021
Merged

feat: handle empty platforms folder #5463

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
25d5ee9
feat: handle empty platforms folder
janoshrubos Jan 7, 2021
5fe0717
chore: shorter warning message
janoshrubos Jan 12, 2021
f8954a0
fix: platformDirectoryItemCount variable name
janoshrubos Jan 12, 2021
5ce5c5f
chore: explaining platformDirectoryItemCount check
janoshrubos Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions lib/controllers/platform-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,23 @@ export class PlatformController implements IPlatformController {
const hasPlatformDirectory = this.$fs.exists(
path.join(projectData.platformsDir, platformName)
);

if (hasPlatformDirectory) {
const platformDirectoryItemCount = this.$fs.readDirectory(
path.join(projectData.platformsDir, platformName)
).length;

// 5 is a magic number to approximate a valid platform folder
// any valid platform should contain at least 5 files
// we choose 5 to avoid false-positives due to system files like .DS_Store etc.
if (platformDirectoryItemCount <= 5) {
this.$logger.warn(
`The platforms/${platformName} folder appears to be invalid. If the build fails, run 'ns clean' and rebuild the app.`,
{ wrapMessageWithBorders: true }
);
}
}

const shouldAddNativePlatform =
!nativePrepare || !nativePrepare.skipNativePrepare;
const prepareInfo = this.$projectChangesService.getPrepareInfo(
Expand Down