router write changes. No writing to all replicas#129
Merged
Conversation
pkarumanchi9
approved these changes
Jul 12, 2022
pkarumanchi9
left a comment
pkarumanchi9
left a comment
Contributor
There was a problem hiding this comment.
Let's release a candidate build with these changes.
| clients = _pool.getEVCacheClientForWrite(); | ||
| } else { | ||
| EVCacheClient client = _pool.getEVCacheClientForRead(); | ||
| if (client == null) { |
Contributor
There was a problem hiding this comment.
Can you please add a comment on why client can be null?
|
|
||
| private EVCacheClient[] getClientsForWrite() { | ||
| EVCacheClient[] clients; | ||
| if (clientWriteToAllReplicas.get()) { |
Contributor
There was a problem hiding this comment.
If router instance is down or the tcp connection is severed, we need to handle the retries. For now, lets push these changes and release a candidate build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
router write changes. No writing to all replicas