Repository navigation
Match query param names verbatim in HttpQueryParams.get - #2213
Merged
Merged
Conversation
lenamonj
requested review from
AlexanderEllis,
argha-c,
fool1280,
gavinbunney,
ilanachalom,
jguerra,
lindseyreynolds,
matthoffman and
tappenzeller
as code owners
September 6, 2026 08:41
jguerra
approved these changes
Sep 23, 2026
jguerra
left a comment
jguerra
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HttpQueryParams.get(String)lower-cased the lookup key while names are stored verbatim, so every parameter whose name carries an uppercase letter returned an empty list, andgetdisagreed withgetFirstandcontains, which match verbatim.containsIgnoreCasefolded only the argument, so it missed a stored name with any uppercase letter.getnow matches the stored name, andcontainsIgnoreCasecompares against the stored names case-insensitively. Three tests cover both; thegetcases fail on master.