refactor(eth2api): making only 1 DataVersion and BuilderVersion#288
refactor(eth2api): making only 1 DataVersion and BuilderVersion#288iamquang95 merged 2 commits intomainfrom
Conversation
|
Could you elaborate on what has changed? How is it that we can merge these two types? |
|
@emlautarom1, previously in the This PR removes that duplication. We now keep a single canonical version type in The main benefit is that it reduces the amount of version/conversion logic we need to maintain. We no longer need to keep two nearly identical types in sync, and any new serialization behavior can now be introduced in one place. |
emlautarom1
left a comment
There was a problem hiding this comment.
Thanks for the explanation. LGTM.
Remove the
DataVersionandBuilderVersionineth2util.