Draft
Conversation
since the internal cluster has a self-signed cert, we can't verify it without adding the root CA to the node environment.
irony
changed the title
mull
reviewed
Feb 10, 2022
| cert-manager.io/cluster-issuer: "letsencrypt-prod" | ||
| nginx.ingress.kubernetes.io/auth-type: basic | ||
| nginx.ingress.kubernetes.io/auth-secret: basic-auth | ||
| nginx.ingress.kubernetes.io/auth-realm: 'Authentication Required - foo' |
mull
reviewed
Feb 10, 2022
mull
reviewed
Feb 21, 2022
packages/web/src/sigil.js
Outdated
|
|
||
| await testQueue | ||
| .add('Test run request from sigil', {test_run_id, arguments: domain}) | ||
| .waitUntilFinished() // todo: when this happens we should send a 'test running... svg' |
Collaborator
There was a problem hiding this comment.
Den här awaiten innebär inte att testet är klart dock, är det det som är tänkt?
packages/web/src/sigil.js
Outdated
| await runOnlyOncePerDomain(domain, async () => { | ||
| console.log('Running test for domain from sigil', domain) | ||
| const parsedUrl = parseUrl(`https://${domain}`) | ||
| const {domain_id} = await connection.one(upsertDomain(parsedUrl.host)) |
Collaborator
There was a problem hiding this comment.
I main är dessa två i en transaction
| // makes sure we only run a function one time per domain using a semaphore in redis | ||
| async function runOnlyOncePerDomain(domain, fn, timeout = 300000) { | ||
| const key = `sigil:${domain}:test_running` | ||
| const semaphore = await redis.get(key) |
Collaborator
There was a problem hiding this comment.
get och set kunde kombineras till ett anrop här. Det spelar väl inte så stor roll, men det går 😬
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use our brand new cluster