-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Update German translations #4930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
LGTM (as a German speaker) |
|
Seems to be good. I would prefer a different translation for " "login.title": "Melden Sie sich bei Ihrem Konto an"," It's way to long, i would prefer "Anmelden" or keep it the english way "Account Login". I think that is pretty clear as a German and "eingedeutscht" |
|
Yeah, it is a bit too long for my taste as well, but I don't particulary like "Account Login". We could go with "Anmelden" like you suggested, or alternatively with "Einloggen". I don't have strong feelings about this either way as I use the UI in English anyway, so you can just decide if you want :) |
Lets do "Anmelden", ok? Rest is fine. |
85fa61d to
afb7250
Compare
|
Done |
|
I've been a bit behind, but if you still want this change can you please rebase and resolve conflicts? |
|
And can someone tell me if #4946 is conflicting with this? |
afb7250 to
1229617
Compare
1229617 to
afb196e
Compare
|
Docker Image for build 4 is available on DockerHub: Note Ensure you backup your NPM instance before testing this image! Especially if there are database changes. Warning Changes and additions to DNS Providers require verification by at least 2 members of the community! |
No description provided.