add support for bq cervantes and fnac touch devices#17
Conversation
|
That's a great start ;). With a bit of luck, there's no weird quirks to take into account, and it's basically all that's needed ;). Speaking of: there's a bunch more ifdeffery involved in fbink_internal.h for the mxcfb header selection, and in fbink_cmd.c for the help message ;). |
|
And, of course, a true no-op in fbink_init to silence that Kobo warning ;). EDIT: Well, identify_device in fbink_device_id.c, actually ;). |
|
@NiLuJe thanks for the hints. I've added device detection based on HWCONFIG pcb ids and added a deviceQuirks for new cervantes3/cervantes4 devices (based on KoboMk7 update). Everything works as expected on my end 😄 Note: refresh for old devices works ok on newer ones as well.
|
5d3928f to
3b0d09c
Compare
|
👍 Yeah, currently, Mk7 Kobo devices also still handle the legacy ioctls ;). |
|
It seems than button_scan binary is built even for kindle. So its out of the scope for this PR. Please feel free to review 👍 |
|
Yep, it just returns ENOSYS on unsupported devices with yet another bit of iffdeffery ;). Besides that, I kind of preferred the typedef in the header and not inside the body of the function ;). That's the only thing that really jumped out after a quick look see, I'll take another look tomorrow, thanks! |
47f42bc to
12caf22
Compare
|
Merging, thanks! (FYI: We don't get notifications on a force push, so don't hesitate to ping when you do that ;)). |
add support for bq cervantes and fnac touchlight devices (a list of devices on https://blog.bq.com/es/bq-ereaders-developers-program/)